Merge #14105: util: Report parse errors in configuration file
ClosedPublic
Actions

Authored by jasonbcox on Jan 18 2020, 00:40.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING05a9f3dd46fb: Merge #14105: util: Report parse errors in configuration file
rABC05a9f3dd46fb: Merge #14105: util: Report parse errors in configuration file

Summary

ed2332aeffb071a3404be9cff8f9fb8a81a9fbfb test: Add test for config file parsing errors (MarcoFalke)
a66c0f78a941968340f030911765a84219908c4d util: Report parse errors in configuration file (Wladimir J. van der Laan)

Pull request description:

Report errors while parsing the configuration file, instead of silently ignoring them.

    $ src/bitcoind -regtest
    Error reading configuration file: parse error on line 22: nodebuglogfile, if you intended to specify a negated option, use nodebuglogfile=1 instead
    $ src/bitcoind -regtest
    Error reading configuration file: parse error on line 22: sdafsdfafs
    $ src/bitcoind -regtest
    Error reading configuration file: parse error on line 24: -nodebuglogfile=1, options in the configuration file must be specified without leading -

(inspired by https://github.com/bitcoin/bitcoin/pull/14100#issuecomment-417264823)

Tree-SHA512: d516342b65db2969edf200390994bbbda23654c648f85dcc99f9f2d217d3d59a72e0f58227be7b4746529dcfa54ba26d8188ba9f14a57c9ab00015d7283fade2

Backport of Core PR14105
https://github.com/bitcoin/bitcoin/pull/14105/files

Test Plan

ninja check
test_runner.py feature_config_args

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr14105

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9039
Build 16040: Default Diff Build & Tests
Build 16039: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jan 18 2020, 00:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 18 2020, 00:40

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9039: Diff 15633.Jan 18 2020, 00:47

jasonbcox added a child revision: D5012: Merge #14494: Error if # is used in rpcpassword in conf.Jan 18 2020, 01:15

deadalnix accepted this revision.Jan 19 2020, 14:21

This revision is now accepted and ready to land.Jan 19 2020, 14:21

Closed by commit rABC05a9f3dd46fb: Merge #14105: util: Report parse errors in configuration file (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyJan 19 2020, 19:19

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC05a9f3dd46fb: Merge #14105: util: Report parse errors in configuration file.

jasonbcox added a commit: rSTAGING05a9f3dd46fb: Merge #14105: util: Report parse errors in configuration file.Apr 7 2020, 22:34

Revision Contents
Changeset List

Path

Size

src/

util/

system.cpp

32 lines

test/

functional/

feature_config_args.py

24 lines

Diff 15633

View Options

src/util/system.cpp