Differential D5115

Add braces to GUI files
ClosedPublic
Actions

Authored by Fabien on Jan 30 2020, 21:43.

Details

Reviewers

nakihito

Group Reviewers

Restricted Project

Commits

rSTAGING5e1f8b83b115: Add braces to GUI files
rABC5e1f8b83b115: Add braces to GUI files

Summary

As per title.

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

braces_gui

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9212
Build 16370: Default Diff Build & Tests
Build 16369: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 30 2020, 21:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 30 2020, 21:43

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9206: Diff 15901.Jan 30 2020, 21:50

Edit: Ignore nits. I see this is part/result of a different change/focus.

src/qt/rpcconsole.cpp
1220 ↗	(On Diff #15901)	Since this is already touching this area, would it be out of scope to move the this comment to the line above?
src/qt/splashscreen.cpp
177 ↗	(On Diff #15901)	And here too?

This revision is now accepted and ready to land.Jan 30 2020, 22:31

Move comments on their line while I'm at it.

This revision was landed with ongoing or failed builds.Jan 30 2020, 22:42

Closed by commit rABC5e1f8b83b115: Add braces to GUI files (authored by Fabien). · Explain Why

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC5e1f8b83b115: Add braces to GUI files.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9212: Diff 15911.Jan 30 2020, 23:19

Fabien added a commit: rSTAGING5e1f8b83b115: Add braces to GUI files.Apr 7 2020, 22:43

Revision Contents
Changeset List

Path

Size

src/

qt/

askpassphrasedialog.cpp

4 lines

20 lines

38 lines

4 lines

22 lines

16 lines

6 lines

4 lines

paymentrequestplus.cpp

12 lines

peertablemodel.cpp

23 lines

platformstyle.cpp

17 lines

qvalidatedlineedit.cpp

11 lines

recentrequeststablemodel.cpp

29 lines

rpcconsole.cpp

34 lines

signverifymessagedialog.cpp

12 lines

splashscreen.cpp

7 lines

test/

paymentservertests.cpp

3 lines

trafficgraphwidget.cpp

20 lines

transactiontablemodel.cpp

4 lines

utilitydialog.cpp

8 lines

Diff 15911

View Options

src/qt/askpassphrasedialog.cpp

View Options

src/qt/bantablemodel.cpp

View Options

src/qt/bitcoingui.cpp

View Options

src/qt/csvmodelwriter.cpp

View Options

src/qt/modaloverlay.cpp

View Options

src/qt/optionsdialog.cpp

View Options

src/qt/optionsmodel.cpp

View Options

src/qt/overviewpage.cpp

View Options

src/qt/paymentrequestplus.cpp

View Options

src/qt/peertablemodel.cpp

View Options

src/qt/platformstyle.cpp

View Options

src/qt/qvalidatedlineedit.cpp

View Options

src/qt/recentrequeststablemodel.cpp

View Options

src/qt/rpcconsole.cpp

View Options

src/qt/signverifymessagedialog.cpp

View Options

src/qt/splashscreen.cpp

View Options

src/qt/test/paymentservertests.cpp

View Options

src/qt/trafficgraphwidget.cpp

View Options

src/qt/transactiontablemodel.cpp

View Options

Add braces to GUI filesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 15911

src/qt/askpassphrasedialog.cpp

src/qt/bantablemodel.cpp

src/qt/bitcoingui.cpp

src/qt/csvmodelwriter.cpp

src/qt/modaloverlay.cpp

src/qt/optionsdialog.cpp

src/qt/optionsmodel.cpp

src/qt/overviewpage.cpp

src/qt/paymentrequestplus.cpp

src/qt/peertablemodel.cpp

src/qt/platformstyle.cpp

src/qt/qvalidatedlineedit.cpp

src/qt/recentrequeststablemodel.cpp

src/qt/rpcconsole.cpp

src/qt/signverifymessagedialog.cpp

src/qt/splashscreen.cpp

src/qt/test/paymentservertests.cpp

src/qt/trafficgraphwidget.cpp

src/qt/transactiontablemodel.cpp

src/qt/utilitydialog.cpp

Add braces to GUI files
ClosedPublic
Actions

Revision Contents
Changeset List