Page MenuHomePhabricator

scratch space: use single allocation
ClosedPublic

Authored by deadalnix on Feb 4 2020, 00:44.

Details

Summary
  • scratch: add magic bytes to beginning of structure
  • scratch space: thread error_callback into all scratch space functions

Use it when checking magic bytes

  • scratch: unify allocations
  • scratch: rename max_size to size, document that extra will actually be allocated
  • scratch: save a couple bytes of unnecessarily-allocated memory
  • scratch: replace frames with "checkpoint" system

This is a backport of secp256k1 PR600

Test Plan
ninja check-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Branch
secppr600
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9253
Build 16449: Default Diff Build & Tests
Build 16448: arc lint + arc unit