Page MenuHomePhabricator

[CMAKE] Fix incompatibility between clang-tidy and -fstack-reuse
ClosedPublic

Authored by Fabien on Feb 4 2020, 09:31.

Details

Summary

This flag is GCC only, but will be passed to the clang-tidy options
causing a diagnostic error. This diff prevents using the incompatible
flag when clang-tidy is enabled.
Since this is a hard error, it cannot be filtered out.

Test Plan

With GCC and clang-tidy enabled:

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_fix_fstack_reuse_clang_tidy
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9255
Build 16452: Default Diff Build & Tests
Build 16451: arc lint + arc unit