Page MenuHomePhabricator
Differential D5156

Merge #13962: Remove unused dummy_tx variable from FillPSBT
ClosedPublic
Actions

Authored by jasonbcox on Feb 4 2020, 22:53.

Details

Reviewers
nakihito
Group Reviewers
Restricted Project
Commits
rSTAGING5da8726f1935: Merge #13962: Remove unused dummy_tx variable from FillPSBT
rABC5da8726f1935: Merge #13962: Remove unused dummy_tx variable from FillPSBT
Summary

16bcc1b8237698c96b8ced2fa7eb76388c7ba85e Remove unused dummy_tx variable from FillPSBT (Carl Dong)

Pull request description:

Tree-SHA512: e7652126bca2e87d445d4190aa0b4192d9575bc0c280d063302ca420be51e7a04fcbc24e0e7f5ec1f18938f0a596901e1285e9afc9b33ca3da78177938791163

Backport of Core PR13962

https://github.com/bitcoin/bitcoin/pull/13962/files

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr13962
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9267
Build 16476: Default Diff Build & Tests
Build 16475: arc lint + arc unit

Event Timeline

jasonbcox planned changes to this revision.Feb 4 2020, 22:53
jasonbcox created this revision.
teamcity edited the summary of this revision. (Show Details)Feb 4 2020, 22:53

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Feb 4 2020, 22:53

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox requested review of this revision.Feb 4 2020, 22:58
teamcity added a comment.Feb 4 2020, 22:58

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9267: Diff 16014.Feb 4 2020, 22:58
nakihito accepted this revision.Feb 4 2020, 23:11
This revision is now accepted and ready to land.Feb 4 2020, 23:11
Closed by commit rABC5da8726f1935: Merge #13962: Remove unused dummy_tx variable from FillPSBT (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyFeb 4 2020, 23:37
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC5da8726f1935: Merge #13962: Remove unused dummy_tx variable from FillPSBT.
jasonbcox added a commit: rSTAGING5da8726f1935: Merge #13962: Remove unused dummy_tx variable from FillPSBT.Apr 7 2020, 22:48

Revision Contents
Changeset List

PathSize
src/
wallet/
5 lines

Diff 16014

View Options

src/wallet/rpcwallet.cpp

Loading...