Page MenuHomePhabricator
Differential D5203

[LINTER] Prevent using inline doxygen comments on their own line
ClosedPublic
Actions

Authored by Fabien on Feb 7 2020, 15:29.

Details

Reviewers
markblundeberg
Group Reviewers
Restricted Project
Commits
rSTAGINGbb3ad402c4d5: [LINTER] Prevent using inline doxygen comments on their own line
rABCbb3ad402c4d5: [LINTER] Prevent using inline doxygen comments on their own line
Summary

This will prevent issues like D5180 to occur again.

Test Plan

Add a few doxygen inline comments in a source file such as:

///< A comment
//!< another comment
/**< yet another comment */
/*!< my last comment */

Run arc lint and check the linter offers to replace with the
non-inline equivalent.

arc lint --everything

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Feb 7 2020, 15:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 7 2020, 15:29
teamcity added a comment.Feb 7 2020, 15:29

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg added a subscriber: markblundeberg.Feb 7 2020, 15:31

Oh yeah good catch on those **< !

markblundeberg accepted this revision.Feb 7 2020, 15:33
This revision is now accepted and ready to land.Feb 7 2020, 15:33
teamcity added a comment.Feb 7 2020, 15:34

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9331: Diff 16119.Feb 7 2020, 15:34
Fabien updated this revision to Diff 16125.Feb 7 2020, 16:12

Rebase.

teamcity added a comment.Feb 7 2020, 16:19

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 7 2020, 16:31

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9333: Diff 16125.Feb 7 2020, 16:32
Closed by commit rABCbb3ad402c4d5: [LINTER] Prevent using inline doxygen comments on their own line (authored by Fabien). · Explain WhyFeb 7 2020, 16:33
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCbb3ad402c4d5: [LINTER] Prevent using inline doxygen comments on their own line.
Fabien added a commit: rSTAGINGbb3ad402c4d5: [LINTER] Prevent using inline doxygen comments on their own line.Apr 7 2020, 22:53

Revision Contents
Changeset List

Diff 16129

View Options

.arclint

Loading...
View Options

arcanist/.phutil_module_cache

Loading...
View Options

arcanist/__phutil_library_map__.php

Loading...
View Options

arcanist/linter/DoxygenLinter.php

Loading...
View Options

src/qt/addresstablemodel.h

Loading...
View Options

src/qt/transactionrecord.h

Loading...