[SECP256K1] Fix ability to compile tests without -DVERIFY.
ClosedPublic
Actions

Authored by Fabien on Feb 19 2020, 08:55.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING1b90ab7f06be: [SECP256K1] Fix ability to compile tests without -DVERIFY.
rABC1b90ab7f06be: [SECP256K1] Fix ability to compile tests without -DVERIFY.

Summary

It's important that the tests are also run without -DVERIFY due to
 the possibility that side-effects of a VERIFY_CHECK fix a bug that
 would otherwise be detected.

Use of the verify_check macro in tests isn't sufficient.

Backport of secp256k1 PR628:
https://github.com/bitcoin-core/secp256k1/pull/628

This will also fix the build with coverage for secp256k1.

Test Plan

ninja check-secp256k1-tests

On secp256k1 standalone:

../configure --enable-coverage # will undefine VERIFY
make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

secp256k1_PR628

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9530
Build 16970: Default Diff Build & Tests
Build 16969: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 19 2020, 08:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 19 2020, 08:55

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9530: Diff 16442.Feb 19 2020, 09:05

Fabien retitled this revision from Fix ability to compile tests without -DVERIFY. to [SECP256K1] Fix ability to compile tests without -DVERIFY..Feb 19 2020, 10:10

jasonbcox accepted this revision.Feb 19 2020, 22:58

This revision is now accepted and ready to land.Feb 19 2020, 22:58

Closed by commit rABC1b90ab7f06be: [SECP256K1] Fix ability to compile tests without -DVERIFY. (authored by Gregory Maxwell <greg@xiph.org>, committed by Fabien). · Explain WhyFeb 20 2020, 12:52

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC1b90ab7f06be: [SECP256K1] Fix ability to compile tests without -DVERIFY..

Fabien added a commit: rSTAGING1b90ab7f06be: [SECP256K1] Fix ability to compile tests without -DVERIFY..Apr 7 2020, 23:04