Paths

Table of Contentst

Differential D5341

[backport] Qt: Replace remaining 0 with nullptr #15114
ClosedPublic
Actions

Authored by majcosta on Feb 27 2020, 21:50.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGd70c6bbf1463: [backport] Qt: Replace remaining 0 with nullptr #15114
rABCd70c6bbf1463: [backport] Qt: Replace remaining 0 with nullptr #15114

Summary

3a0e76fc12b91b2846d756981e15f09b767a9c37 Replace remaining 0 with nullptr in Qt code (Ben Woosley)
9096276e0b2d5b7e19af9a5f3c144ef108ee55e0 Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) (practicalswift)

Pull request description:

This corrects all violations of -Wzero-as-null-pointer-constant identified in the Qt codebase.

These changes are extracted from #15112 as suggested by @MarcoFalke to ease review. This is in service of enabling -Wzero-as-null-pointer-constant, which should eliminate this as a concern going forward.

Note there are 2 non-Qt changes: src/test/allocator_tests.cpp and src/wallet/db.cpp.

This is a backport from Core PR15114 (https://github.com/bitcoin/bitcoin/pull/15114)

Test Plan

ninja check
ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

replace_zero_with_nullptr

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9598
Build 17097: Default Diff Build & Tests
Build 17096: arc lint + arc unit

Event Timeline

majcosta created this revision.Feb 27 2020, 21:50

Owners added a reviewer: Restricted Owners Package.Feb 27 2020, 21:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 27 2020, 21:50

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9598: Diff 16552.Feb 27 2020, 22:08

deadalnix accepted this revision.Feb 27 2020, 23:22

This revision is now accepted and ready to land.Feb 27 2020, 23:22

Closed by commit rABCd70c6bbf1463: [backport] Qt: Replace remaining 0 with nullptr #15114 (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by majcosta). · Explain WhyFeb 27 2020, 23:31

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCd70c6bbf1463: [backport] Qt: Replace remaining 0 with nullptr #15114.

majcosta added a commit: rSTAGINGd70c6bbf1463: [backport] Qt: Replace remaining 0 with nullptr #15114.Apr 7 2020, 23:06

Revision Contents
Changeset List

Path

Size

src/

qt/

addressbookpage.cpp

2 lines

addresstablemodel.h

2 lines

addresstablemodel.cpp

2 lines

askpassphrasedialog.cpp

4 lines

bantablemodel.h

3 lines

bantablemodel.cpp

4 lines

33 lines

bitcoinamountfield.h

4 lines

bitcoinamountfield.cpp

10 lines

3 lines

8 lines

2 lines

clientmodel.cpp

2 lines

coincontroldialog.h

2 lines

coincontroldialog.cpp

2 lines

coincontroltreewidget.h

2 lines

csvmodelwriter.h

2 lines

csvmodelwriter.cpp

2 lines

editaddressdialog.cpp

4 lines

2 lines

6 lines

networkstyle.cpp

2 lines

optionsdialog.cpp

3 lines

2 lines

2 lines

overviewpage.cpp

3 lines

paymentserver.cpp

6 lines

peertablemodel.h

3 lines

peertablemodel.cpp

7 lines

platformstyle.cpp

2 lines

qvalidatedlineedit.cpp

2 lines

qvaluecombobox.h

2 lines

receivecoinsdialog.h

2 lines

receivecoinsdialog.cpp

5 lines

receiverequestdialog.h

4 lines

receiverequestdialog.cpp

5 lines

2 lines

sendcoinsdialog.cpp

2 lines

sendcoinsentry.cpp

2 lines

signverifymessagedialog.cpp

2 lines

splashscreen.cpp

2 lines

trafficgraphwidget.h

2 lines

trafficgraphwidget.cpp

4 lines

transactiondescdialog.h

3 lines

transactionfilterproxy.h

2 lines

transactiontablemodel.h

2 lines

transactiontablemodel.cpp

2 lines

transactionview.h

2 lines

transactionview.cpp

5 lines

walletmodel.cpp

4 lines

test/

allocator_tests.cpp

6 lines

wallet/

3 lines

Diff 16552

src/qt/addressbookpage.cpp

Loading...

src/qt/addresstablemodel.h

Loading...

src/qt/addresstablemodel.cpp

Loading...

src/qt/askpassphrasedialog.cpp

Loading...

src/qt/bantablemodel.h

Loading...

src/qt/bantablemodel.cpp

Loading...

src/qt/bitcoin.cpp

Loading...

src/qt/bitcoinamountfield.h

Loading...

src/qt/bitcoinamountfield.cpp

Loading...

src/qt/bitcoingui.h

Loading...

src/qt/bitcoingui.cpp

Loading...

src/qt/clientmodel.h

Loading...

src/qt/clientmodel.cpp

Loading...

src/qt/coincontroldialog.h

Loading...

src/qt/coincontroldialog.cpp

Loading...

src/qt/coincontroltreewidget.h

Loading...

src/qt/csvmodelwriter.h

Loading...

src/qt/csvmodelwriter.cpp

Loading...

src/qt/editaddressdialog.cpp

Loading...

src/qt/intro.h

Loading...

src/qt/intro.cpp

Loading...

src/qt/networkstyle.cpp

Loading...

src/qt/optionsdialog.cpp

Loading...

src/qt/optionsmodel.h

Loading...

src/qt/overviewpage.h

Loading...

src/qt/overviewpage.cpp

Loading...

src/qt/paymentserver.cpp

Loading...

src/qt/peertablemodel.h

Loading...

src/qt/peertablemodel.cpp

Loading...

src/qt/platformstyle.cpp

Loading...

src/qt/qvalidatedlineedit.cpp

Loading...

src/qt/qvaluecombobox.h

Loading...

src/qt/receivecoinsdialog.h

Loading...

src/qt/receivecoinsdialog.cpp

Loading...

src/qt/receiverequestdialog.h

Loading...

src/qt/receiverequestdialog.cpp

Loading...

src/qt/rpcconsole.cpp

Loading...

src/qt/sendcoinsdialog.cpp

Loading...

src/qt/sendcoinsentry.cpp

Loading...

src/qt/signverifymessagedialog.cpp

Loading...

src/qt/splashscreen.cpp

Loading...

src/qt/trafficgraphwidget.h

Loading...

src/qt/trafficgraphwidget.cpp

Loading...

src/qt/transactiondescdialog.h

Loading...

src/qt/transactionfilterproxy.h

Loading...

src/qt/transactiontablemodel.h

Loading...

src/qt/transactiontablemodel.cpp

Loading...

src/qt/transactionview.h

Loading...

src/qt/transactionview.cpp

Loading...

src/qt/walletmodel.cpp

Loading...

src/test/allocator_tests.cpp

Loading...

src/wallet/db.cpp

Loading...