Page MenuHomePhabricator
Differential D5369

[backport] qt: Replace functions deprecated in Qt 5.13 #16701
ClosedPublic
Actions

Authored by majcosta on Feb 28 2020, 14:57.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING93934d3b8072: [backport] qt: Replace functions deprecated in Qt 5.13 #16701
rABC93934d3b8072: [backport] qt: Replace functions deprecated in Qt 5.13 #16701
Summary

c6dd32da697e5a8052cbabe8c7605d27c43a8dfb qt: Replace obsolete functions of QDesktopWidget (Hennadii Stepanov)
1260ecd812e35185898fd555ad3e01d019072bcf qt: Add TextWidth() wrapper (Hennadii Stepanov)

Pull request description:

The following functions are obsolete in Qt 5.13:

This PR replaces them and does not change behavior.

This is a backport from Core PR16701

Test Plan
ninja check
run bitcoin-qt and click around to see everything is sane

Diff Detail

Repository
rABC Bitcoin ABC
Branch
replace_deprecated
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9641
Build 17182: Default Diff Build & Tests
Build 17181: arc lint + arc unit

Event Timeline

majcosta created this revision.Feb 28 2020, 14:57
Owners added a reviewer: Restricted Owners Package.Feb 28 2020, 14:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 28 2020, 14:57
teamcity edited the summary of this revision. (Show Details)Feb 28 2020, 14:57

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Feb 28 2020, 14:57

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 28 2020, 15:15

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9637: Diff 16615.Feb 28 2020, 15:16
majcosta planned changes to this revision.Feb 28 2020, 15:36
majcosta updated this revision to Diff 16625.Feb 28 2020, 17:39

removed calculateIdealFontSize function that is not part of this PR

teamcity added a comment.Feb 28 2020, 17:39

Build Bitcoin-ABC / Diffs / Diff Testing started.

majcosta abandoned this revision.Feb 28 2020, 17:40
teamcity added a comment.Feb 28 2020, 18:01

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9640: Diff 16625.Feb 28 2020, 18:01
majcosta reclaimed this revision.Feb 28 2020, 18:04
majcosta planned changes to this revision.
majcosta updated this revision to Diff 16626.Feb 28 2020, 19:15

fixing my own mess

teamcity added a comment.Feb 28 2020, 19:15

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 28 2020, 19:37

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9641: Diff 16626.Feb 28 2020, 19:37
deadalnix accepted this revision.Feb 28 2020, 23:53
This revision is now accepted and ready to land.Feb 28 2020, 23:53
Closed by commit rABC93934d3b8072: [backport] qt: Replace functions deprecated in Qt 5.13 #16701 (authored by Wladimir J. van der Laan <laanwj@protonmail.com>, committed by majcosta). · Explain WhyFeb 29 2020, 00:13
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC93934d3b8072: [backport] qt: Replace functions deprecated in Qt 5.13 #16701.
majcosta added a commit: rSTAGING93934d3b8072: [backport] qt: Replace functions deprecated in Qt 5.13 #16701.Apr 7 2020, 23:10

Revision Contents
Changeset List

PathSize
src/
qt/
8 lines
7 lines
10 lines
9 lines
4 lines
16 lines

Diff 16626

View Options

src/qt/bitcoinamountfield.cpp

Loading...
View Options

src/qt/bitcoingui.cpp

Loading...
View Options

src/qt/guiutil.h

Loading...
View Options

src/qt/guiutil.cpp

Loading...
View Options

src/qt/rpcconsole.cpp

Loading...
View Options

src/qt/splashscreen.cpp

Loading...