Page MenuHomePhabricator
Differential D5385

[backport] qt: Remove obsolete QModelIndex::child() #16707
ClosedPublic
Actions

Authored by majcosta on Feb 29 2020, 17:12.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING5bd34749056f: [backport] qt: Remove obsolete QModelIndex::child() #16707
rABC5bd34749056f: [backport] qt: Remove obsolete QModelIndex::child() #16707
Summary

c53667764ea65c0f8661358759b0124f808ce587 qt: Remove obsolete QModelIndex::child() (Hennadii Stepanov)

Pull request description:

The QModelIndex::child() member function is obsolete since Qt 5.12.

This PR removes it, does not change behavior and keeps compatibility with Qt 5.5.1.

This is a backport of Core PR16707

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Feb 29 2020, 17:12
Owners added a reviewer: Restricted Owners Package.Feb 29 2020, 17:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 29 2020, 17:12
teamcity edited the summary of this revision. (Show Details)Feb 29 2020, 17:12

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Feb 29 2020, 17:12

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 29 2020, 17:21

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9666: Diff 16664.Feb 29 2020, 17:21
deadalnix accepted this revision.Feb 29 2020, 23:04
This revision is now accepted and ready to land.Feb 29 2020, 23:04
Closed by commit rABC5bd34749056f: [backport] qt: Remove obsolete QModelIndex::child() #16707 (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by majcosta). · Explain WhyFeb 29 2020, 23:20
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC5bd34749056f: [backport] qt: Remove obsolete QModelIndex::child() #16707.
majcosta added a commit: rSTAGING5bd34749056f: [backport] qt: Remove obsolete QModelIndex::child() #16707.Apr 7 2020, 23:10

Revision Contents
Changeset List

Diff 16670

View Options

src/qt/receivecoinsdialog.cpp

Loading...
View Options

src/qt/recentrequeststablemodel.h

Loading...