Differential D5449

[CMAKE] Improve FindGMP
ClosedPublic
Actions

Authored by Fabien on Mar 9 2020, 12:51.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING470b2e97015e: [CMAKE] Improve FindGMP
rABC470b2e97015e: [CMAKE] Improve FindGMP

Summary

Build an imported target and allow to filter on version (unused as I
don't know what is the minimum required).

Test Plan

cmake -GNinja .. -DSECP256K1_ENABLE_BIGNUM=ON
ninja check-secp256k1

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmake_find_gmp

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9763
Build 17405: Default Diff Build & Tests
Build 17404: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 9 2020, 12:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 9 2020, 12:51

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B9763: Diff 16839.Mar 9 2020, 13:02

Build Bitcoin-ABC / Diffs / Diff Testing passed.

jasonbcox accepted this revision.Mar 10 2020, 17:04

This revision is now accepted and ready to land.Mar 10 2020, 17:04

Closed by commit rABC470b2e97015e: [CMAKE] Improve FindGMP (authored by Fabien). · Explain WhyMar 11 2020, 15:40

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC470b2e97015e: [CMAKE] Improve FindGMP.

Fabien added a commit: rSTAGING470b2e97015e: [CMAKE] Improve FindGMP.Apr 7 2020, 23:18

Revision Contents
Changeset List

Path

Size

cmake/

modules/

FindGMP.cmake

109 lines

src/

secp256k1/

CMakeLists.txt

3 lines

Diff 16839

View Options

cmake/modules/FindGMP.cmake