Page MenuHomePhabricator
Differential D5453

[CMAKE] Improve FindSHLWAPI
ClosedPublic
Actions

Authored by Fabien on Mar 9 2020, 13:53.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGf1473deabdf6: [CMAKE] Improve FindSHLWAPI
rABCf1473deabdf6: [CMAKE] Improve FindSHLWAPI
Summary

This makes the FindSHLWAPI consistent with the other find modules.
There are few benefits right now because the imported target cannot be
used due to cmake bugs
(https://gitlab.kitware.com/cmake/cmake/issues/16291,
https://gitlab.kitware.com/cmake/cmake/issues/19095) but makes it future
proof when cmake > 3.14.1 get enforced.

Test Plan
ninja check

Run the Gitian builds.

I also tested using the imported target with cmake 3.14.1.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_find_shlwapi
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9769
Build 17417: Default Diff Build & Tests
Build 17416: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 9 2020, 13:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 9 2020, 13:53
teamcity added a comment.Mar 9 2020, 13:53

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Mar 9 2020, 13:55

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Mar 9 2020, 13:55

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Mar 9 2020, 13:59

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

teamcity added a comment.Mar 9 2020, 13:59

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Mar 9 2020, 14:04

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9769: Diff 16845.Mar 9 2020, 14:04
teamcity added a comment.Mar 9 2020, 14:07

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

teamcity added a comment.Mar 9 2020, 14:08

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

jasonbcox accepted this revision.Mar 11 2020, 03:08
This revision is now accepted and ready to land.Mar 11 2020, 03:08
Closed by commit rABCf1473deabdf6: [CMAKE] Improve FindSHLWAPI (authored by Fabien). · Explain WhyMar 11 2020, 15:47
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCf1473deabdf6: [CMAKE] Improve FindSHLWAPI.
Fabien added a commit: rSTAGINGf1473deabdf6: [CMAKE] Improve FindSHLWAPI.Apr 7 2020, 23:18

Revision Contents
Changeset List

PathSize
cmake/
modules/
53 lines
src/
12 lines
leveldb/
12 lines

Diff 16845

View Options

cmake/modules/FindSHLWAPI.cmake

Loading...
View Options

src/CMakeLists.txt

Loading...
View Options

src/leveldb/CMakeLists.txt

Loading...