Page MenuHomePhabricator
Differential D5517

Merge #14373: Consistency fixes for RPC descriptions
ClosedPublic
Actions

Authored by nakihito on Mar 19 2020, 20:32.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING9d64eabb34a7: Merge #14373: Consistency fixes for RPC descriptions
rABC9d64eabb34a7: Merge #14373: Consistency fixes for RPC descriptions
Summary

b8edb9810a [rpc] Descriptions: Textual consistency fixes (Jon Layton)

Pull request description:

Tree-SHA512: fa22ddac94e95672579cc84309f1c3ea3a2dbf762e45a8ae9c121c4c5188bf8c19ff9458d49dd7ef760c3ae4226487612a2954e9a1a0e8b720116afeb718b46b

Backport of Core PR14373

Test Plan
ninja
ninja check
./bitcoind
./bitcoin-cli help <changed rpcs>

Verify changes in help text.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14373
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9896
Build 17651: Default Diff Build & Tests
Build 17650: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 19 2020, 20:32
Owners added a reviewer: Restricted Owners Package.Mar 19 2020, 20:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 19 2020, 20:32
teamcity edited the summary of this revision. (Show Details)Mar 19 2020, 20:32

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 19 2020, 20:32

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 19 2020, 20:42

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9896: Diff 17059.Mar 19 2020, 20:42
deadalnix accepted this revision.Mar 20 2020, 00:41
This revision is now accepted and ready to land.Mar 20 2020, 00:41
Closed by commit rABC9d64eabb34a7: Merge #14373: Consistency fixes for RPC descriptions (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhyMar 20 2020, 01:38
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC9d64eabb34a7: Merge #14373: Consistency fixes for RPC descriptions.
nakihito added a commit: rSTAGING9d64eabb34a7: Merge #14373: Consistency fixes for RPC descriptions.Apr 7 2020, 23:24

Revision Contents
Changeset List

PathSize
src/
rpc/
20 lines
8 lines
14 lines
wallet/
30 lines

Diff 17059

View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/rpc/misc.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...