Page MenuHomePhabricator
Differential D5538

utils: Convert fs error messages from multibyte to utf-8
ClosedPublic
Actions

Authored by Fabien on Mar 23 2020, 08:32.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGe4064a672826: utils: Convert fs error messages from multibyte to utf-8
rABCe4064a672826: utils: Convert fs error messages from multibyte to utf-8
Summary

Backport of core PR14192.

Test Plan
ninja check check-functional

Run the Windows Gitian build.

On Windows:

./bitcoin-qt.exe -regtest -wallet=???

Before:

windows_utf8_bad.PNG (191×502 px, 9 KB)

After:
windows_utf8_good.PNG (191×502 px, 9 KB)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14192
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9928
Build 17715: Default Diff Build & Tests
Build 17714: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 23 2020, 08:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 23 2020, 08:33
teamcity edited the summary of this revision. (Show Details)Mar 23 2020, 08:33

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 23 2020, 08:33

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien edited the test plan for this revision. (Show Details)Mar 23 2020, 08:34
teamcity added a comment.Mar 23 2020, 08:36

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) started.

teamcity added a comment.Mar 23 2020, 08:44

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) passed.

teamcity added a comment.Mar 23 2020, 08:45

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9928: Diff 17110.Mar 23 2020, 08:45
jasonbcox accepted this revision.Mar 23 2020, 18:19
This revision is now accepted and ready to land.Mar 23 2020, 18:19
Closed by commit rABCe4064a672826: utils: Convert fs error messages from multibyte to utf-8 (authored by Chun Kuan Lee <ken2812221@gmail.com>, committed by Fabien). · Explain WhyMar 24 2020, 09:33
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCe4064a672826: utils: Convert fs error messages from multibyte to utf-8.
Fabien added a commit: rSTAGINGe4064a672826: utils: Convert fs error messages from multibyte to utf-8.Apr 7 2020, 23:26

Revision Contents
Changeset List

PathSize
src/
2 lines
18 lines
rpc/
2 lines
wallet/
3 lines
5 lines

Diff 17110

View Options

src/fs.h

Loading...
View Options

src/fs.cpp

Loading...
View Options

src/rpc/protocol.cpp

Loading...
View Options

src/wallet/db.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...