Fix setexcessiveblock rpc help text
ClosedPublic
Actions

Authored by nakihito on Mar 25 2020, 19:01.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING58a87f61a851: Fix setexcessiveblock rpc help text
rABC58a87f61a851: Fix setexcessiveblock rpc help text

Summary

Help text did not contain any information about its arguments despite
requiring one.

Test Plan

ninja
./bitcoind
./bitcoin-cli help setexcessiveblock

Verify change in help text.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

FixExcessiveBlockHelp

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9970
Build 17790: Default Diff Build & Tests
Build 17789: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 25 2020, 19:01

Owners added a reviewer: Restricted Owners Package.Mar 25 2020, 19:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 25 2020, 19:01

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fix copy-paste typo.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9970: Diff 17170.Mar 25 2020, 19:11

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9971: Diff 17172.Mar 25 2020, 19:29

nakihito mentioned this in D5548: Partial Merge #14726: Use RPCHelpMan for all RPCs.Mar 25 2020, 19:40

nakihito added a child revision: D5548: Partial Merge #14726: Use RPCHelpMan for all RPCs.

jasonbcox accepted this revision.Mar 25 2020, 20:02

This revision is now accepted and ready to land.Mar 25 2020, 20:02

Closed by commit rABC58a87f61a851: Fix setexcessiveblock rpc help text (authored by nakihito). · Explain WhyMar 25 2020, 20:15

This revision was automatically updated to reflect the committed changes.

nakihito added a commit: rABC58a87f61a851: Fix setexcessiveblock rpc help text.

nakihito added a commit: rSTAGING58a87f61a851: Fix setexcessiveblock rpc help text.Apr 7 2020, 23:27

Revision Contents
Changeset List

Path

Size

src/

rpc/

abc.cpp

11 lines

Diff 17170

View Options

Fix setexcessiveblock rpc help textClosedPublicActions