[CMAKE] Pass the interface linked libraries to find_component
ClosedPublic
Actions

Authored by Fabien on Mar 26 2020, 17:06.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGb511395ba352: [CMAKE] Pass the interface linked libraries to find_component
rABCb511395ba352: [CMAKE] Pass the interface linked libraries to find_component

Summary

This will avoid code duplication as some other libraries will be using
the feature (namely miniupnpc and zmq).
There is no change in behavior.

Test Plan

Run the windows Gitian build.
Build the benchmark on Windows.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmake_interface_link_libraries

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9986
Build 17820: Default Diff Build & Tests
Build 17819: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 26 2020, 17:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 26 2020, 17:06

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien mentioned this in D5575: [CMAKE] Pull miniupnpc windows library dependencies in the find module.Mar 26 2020, 17:08

Fabien added a child revision: D5575: [CMAKE] Pull miniupnpc windows library dependencies in the find module.Mar 26 2020, 17:09

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9986: Diff 17208.Mar 26 2020, 17:16

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) started.

Fabien added a child revision: D5577: [CMAKE] Pull zmq windows library dependencies in the find module.Mar 26 2020, 17:20

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) passed.

jasonbcox accepted this revision.Mar 26 2020, 20:31

This revision is now accepted and ready to land.Mar 26 2020, 20:31

Closed by commit rABCb511395ba352: [CMAKE] Pass the interface linked libraries to find_component (authored by Fabien). · Explain WhyMar 27 2020, 17:26

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCb511395ba352: [CMAKE] Pass the interface linked libraries to find_component.

Fabien added a commit: rSTAGINGb511395ba352: [CMAKE] Pass the interface linked libraries to find_component.Apr 7 2020, 23:31

Revision Contents
Changeset List

Path

Size

cmake/

modules/

ExternalLibraryHelper.cmake

10 lines

FindEvent.cmake

7 lines

Diff 17208

View Options

cmake/modules/ExternalLibraryHelper.cmake