Page MenuHomePhabricator
Differential D5577

[CMAKE] Pull zmq windows library dependencies in the find module
ClosedPublic
Actions

Authored by Fabien on Mar 26 2020, 17:20.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGd45a3e8756de: [CMAKE] Pull zmq windows library dependencies in the find module
rABCd45a3e8756de: [CMAKE] Pull zmq windows library dependencies in the find module
Summary

Similar to what is done with event and miniupnpc, this adds the required
windows libraries to zmq. This will allow to build with versions >= 4.2
which require iphlpapi while remaining compatible with older versions.

Depends on D5576.

Test Plan

Run the Windows Gitian build.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_zmq_iphlpapi
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9988
Build 17824: Default Diff Build & Tests
Build 17823: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 26 2020, 17:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 26 2020, 17:20
teamcity added a comment.Mar 26 2020, 17:21

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien mentioned this in D5574: [depends] ZeroMQ 4.2.2.Mar 26 2020, 17:21
Fabien added a child revision: D5574: [depends] ZeroMQ 4.2.2.Mar 26 2020, 17:21
teamcity added a comment.Mar 26 2020, 17:30

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9988: Diff 17210.Mar 26 2020, 17:30
teamcity added a comment.Mar 26 2020, 20:36

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) started.

jasonbcox accepted this revision.Mar 26 2020, 20:38
This revision is now accepted and ready to land.Mar 26 2020, 20:38
teamcity added a comment.Mar 26 2020, 20:44

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) passed.

Closed by commit rABCd45a3e8756de: [CMAKE] Pull zmq windows library dependencies in the find module (authored by Fabien). · Explain WhyMar 27 2020, 17:28
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCd45a3e8756de: [CMAKE] Pull zmq windows library dependencies in the find module.
Fabien added a commit: rSTAGINGd45a3e8756de: [CMAKE] Pull zmq windows library dependencies in the find module.Apr 7 2020, 23:31

Revision Contents
Changeset List

PathSize
cmake/
modules/
9 lines

Diff 17210

View Options

cmake/modules/FindZeroMQ.cmake

Loading...