Page MenuHomePhabricator
Differential D5604

depends: Enable unicode support on dbd for Windows
ClosedPublic
Actions

Authored by Fabien on Mar 30 2020, 12:30.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING2a05ba02dcc7: depends: Enable unicode support on dbd for Windows
rABC2a05ba02dcc7: depends: Enable unicode support on dbd for Windows
Summary
define UNICODE and _UNICODE while compiling for Windows. This would make
dbd read filename as utf8 string.

Backport of core PR13884.

Test Plan

Run the Windows Gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13884
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10029
Build 17898: Default Diff Build & Tests
Build 17897: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 30 2020, 12:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 30 2020, 12:30
teamcity added a comment.Mar 30 2020, 12:30

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity edited the summary of this revision. (Show Details)Mar 30 2020, 12:30

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 30 2020, 12:30

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) started.

teamcity added a comment.Mar 30 2020, 12:41

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) passed.

teamcity added a comment.Mar 30 2020, 12:47

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10029: Diff 17274.Mar 30 2020, 12:47
deadalnix accepted this revision.Mar 30 2020, 14:08
This revision is now accepted and ready to land.Mar 30 2020, 14:08
Closed by commit rABC2a05ba02dcc7: depends: Enable unicode support on dbd for Windows (authored by Chun Kuan Lee <ken2812221@gmail.com>, committed by Fabien). · Explain WhyMar 31 2020, 12:17
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC2a05ba02dcc7: depends: Enable unicode support on dbd for Windows.
Fabien added a commit: rSTAGING2a05ba02dcc7: depends: Enable unicode support on dbd for Windows.Apr 7 2020, 23:32

Revision Contents
Changeset List

PathSize
depends/
packages/
1 line

Diff 17274

View Options

depends/packages/bdb.mk

Loading...