Page MenuHomePhabricator
Differential D5620

depends: add ability to skip building zeromq
ClosedPublic
Actions

Authored by Fabien on Mar 31 2020, 13:22.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING19ea95224a94: depends: add ability to skip building zeromq
rABC19ea95224a94: depends: add ability to skip building zeromq
Summary
Similar to other depends packages, add the ability to skip building
zeromq by passing NO_ZMQ=1.

Backport of core PR16089.

Test Plan
cd depends
make build-osx NO_ZMQ=1

Check zmq is not built (under x86_64-apple-darwin16/lib there should
be no libzmq.a).

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR16089
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10052
Build 17940: Default Diff Build & Tests
Build 17939: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 31 2020, 13:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 31 2020, 13:22
teamcity edited the summary of this revision. (Show Details)Mar 31 2020, 13:22

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 31 2020, 15:29

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Harbormaster completed remote builds in B10052: Diff 17319.Mar 31 2020, 15:46
teamcity added a comment.Mar 31 2020, 15:46

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

deadalnix accepted this revision.Mar 31 2020, 19:27
This revision is now accepted and ready to land.Mar 31 2020, 19:27
Closed by commit rABC19ea95224a94: depends: add ability to skip building zeromq (authored by fanquake <fanquake@gmail.com>, committed by Fabien). · Explain WhyApr 1 2020, 07:10
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC19ea95224a94: depends: add ability to skip building zeromq.
Fabien added a commit: rSTAGING19ea95224a94: depends: add ability to skip building zeromq.Apr 7 2020, 23:33

Revision Contents
Changeset List

PathSize
depends/
7 lines
1 line
4 lines
packages/
4 lines

Diff 17319

View Options

depends/Makefile

Loading...
View Options

depends/README.md

Loading...
View Options

depends/config.site.in

Loading...
View Options

depends/packages/packages.mk

Loading...