Page MenuHomePhabricator
Differential D5633

build: disable libxcb extensions
ClosedPublic
Actions

Authored by Fabien on Apr 1 2020, 12:20.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGdc1dc0e40ec7: build: disable libxcb extensions
rABCdc1dc0e40ec7: build: disable libxcb extensions
Summary
Because we pass -qt-xcb to Qt, it will compile in a set of xcb helper
libraries and extensions.
So skip building all of the libxcb extensions when we build libcxb in
depends.

More info is available  here:
https://doc.qt.io/qt-5.9/linux-requirements.html

Backport of core PR16533.

Test Plan

Run the Linux Gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR16533
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10071
Build 17975: Default Diff Build & Tests
Build 17974: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 1 2020, 12:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 1 2020, 12:20
teamcity edited the summary of this revision. (Show Details)Apr 1 2020, 12:20

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 1 2020, 12:20

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien planned changes to this revision.Apr 1 2020, 12:20

Pending gitian builds.

teamcity added a comment.Apr 1 2020, 12:21

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (linux) started.

teamcity added a comment.Apr 1 2020, 12:29

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10071: Diff 17348.Apr 1 2020, 12:29
teamcity added a comment.Apr 1 2020, 13:02

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (linux) passed.

Fabien requested review of this revision.Apr 1 2020, 13:03
deadalnix accepted this revision.Apr 1 2020, 16:39
This revision is now accepted and ready to land.Apr 1 2020, 16:39
Fabien added a child revision: D5642: depends: cleanup package configure flags.Apr 1 2020, 17:32
Closed by commit rABCdc1dc0e40ec7: build: disable libxcb extensions (authored by fanquake <fanquake@gmail.com>, committed by Fabien). · Explain WhyApr 2 2020, 09:15
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCdc1dc0e40ec7: build: disable libxcb extensions.
Fabien added a commit: rSTAGINGdc1dc0e40ec7: build: disable libxcb extensions.Apr 7 2020, 23:35

Revision Contents
Changeset List

PathSize
depends/
packages/
12 lines

Diff 17348

View Options

depends/packages/libxcb.mk

Loading...