Page MenuHomePhabricator
Differential D5648

Remove trailing whitespaces in various files
ClosedPublic
Actions

Authored by Fabien on Apr 2 2020, 12:22.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGcfbd8924e7db: Remove trailing whitespaces in various files
rABCcfbd8924e7db: Remove trailing whitespaces in various files
Summary

As per title. This is a required step before introducing a linter that
automates it.

Test Plan

Read the files and check there is no behavior change.

ninja
make

Diff Detail

Repository
rABC Bitcoin ABC
Branch
whitespace_misc
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10090
Build 18010: Default Diff Build & Tests
Build 18009: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 2 2020, 12:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 2 2020, 12:22
teamcity added a comment.Apr 2 2020, 12:23

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien added a child revision: D5649: [LINTER] Remove trailing whitespaces.Apr 2 2020, 12:28
Harbormaster completed remote builds in B10090: Diff 17384.Apr 2 2020, 12:35
teamcity added a comment.Apr 2 2020, 12:35

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

jasonbcox accepted this revision.Apr 2 2020, 15:51
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
test/functional/rpc_preciousblock.py
54

This is adding a newline. Not sure what the rule is for this one.

This revision is now accepted and ready to land.Apr 2 2020, 15:51
Fabien added inline comments.Apr 2 2020, 19:51
test/functional/rpc_preciousblock.py
54

This is autopep8 or flake8, not related to the trailing whitespaces linter but it will fix arc lint --everything, so I'd better keep it.

Closed by commit rABCcfbd8924e7db: Remove trailing whitespaces in various files (authored by Fabien). · Explain WhyApr 2 2020, 19:51
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCcfbd8924e7db: Remove trailing whitespaces in various files.
Fabien removed a child revision: D5649: [LINTER] Remove trailing whitespaces.Apr 2 2020, 20:00
Fabien added a commit: rSTAGINGcfbd8924e7db: Remove trailing whitespaces in various files.Apr 7 2020, 23:36

Revision Contents
Changeset List

PathSize
build-aux/
m4/
2 lines
2 lines
contrib/
debian/
examples/
10 lines
gitian/
4 lines
6 lines
init/
2 lines
macdeploy/
130 lines
qt/
2 lines
teamcity/
2 lines
testgen/
2 lines
share/
qt/
4 lines
4 lines
src/
2 lines
test/
functional/
1 line
lint/
4 lines

Diff 17384

View Options

build-aux/m4/ax_boost_thread.m4

Loading...
View Options

configure.ac

Loading...
View Options

contrib/debian/examples/bitcoin.conf

Loading...
View Options

contrib/gitian/Vagrantfile

Loading...
View Options

contrib/gitian/provisioner.sh

Loading...
View Options

contrib/init/bitcoind.openrc

Loading...
View Options

contrib/macdeploy/macdeployqtplus

Loading...
View Options

contrib/qt/convert-prl-libs-to-cmake.pl

Loading...
View Options

contrib/teamcity/build-configurations.sh

Loading...
View Options

contrib/testgen/README.md

Loading...
View Options

share/qt/Info.plist.cmake.in

Loading...
View Options

share/qt/Info.plist.in

Loading...
View Options

src/Makefile.qt.include

Loading...
View Options

test/functional/rpc_preciousblock.py

Loading...
View Options

test/lint/lint-python-format-tests.txt

Loading...