Page MenuHomePhabricator

Fix Avalanche functional test when wallet is disabled
ClosedPublic

Authored by jasonbcox on Apr 8 2020, 16:06.

Details

Summary

Similar to D5568, generate() doesn't work when the wallet is disabled.

Test Plan
cmake -GNinja -DBUILD_BITCOIN_WALLET=OFF ..
ninja
./test/functional/test_runner.py abc-p2p-avalanche

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix-ava-without-wallet
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10148
Build 18122: Default Diff Build & Tests
Build 18121: arc lint + arc unit

Event Timeline

Snippet of first build failure:

[16:10:38] :	 [Step 1/2] [99/116] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/merkle_tests.cpp.o
[16:10:38] :	 [Step 1/2] [100/116] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/validation_tests.cpp.o
[16:10:38] :	 [Step 1/2] [101/116] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/key_io_tests.cpp.o
[16:10:39] :	 [Step 1/2] [102/116] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/work_comparator_tests.cpp.o
[16:10:39] :	 [Step 1/2] [103/116] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/versionbits_tests.cpp.o
[16:10:39] :	 [Step 1/2] [104/116] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/denialofservice_tests.cpp.o
[16:10:39] :	 [Step 1/2] [105/116] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/merkleblock_tests.cpp.o
[16:10:40] :	 [Step 1/2] [106/116] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/checkdatasig_tests.cpp.o
[16:10:42] :	 [Step 1/2] [107/116] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/sighashtype_tests.cpp.o
[16:10:44] :	 [Step 1/2] [108/116] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/rpc/test/server_tests.cpp.o
[16:10:44] :	 [Step 1/2] [109/116] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/net_tests.cpp.o
[16:10:44] :	 [Step 1/2] [110/116] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/avalanche_tests.cpp.o
[16:10:44] :	 [Step 1/2] [111/116] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/sigencoding_tests.cpp.o
[16:10:46] :	 [Step 1/2] [112/116] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/uint256_tests.cpp.o
[16:10:47] :	 [Step 1/2] [113/116] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/radix_tests.cpp.o
[16:10:47] :	 [Step 1/2] [114/116] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/rpc_tests.cpp.o
[16:10:56] :	 [Step 1/2] [115/116] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/util_tests.cpp.o
[16:10:58] :	 [Step 1/2] [116/116] Linking CXX executable src/test/test_bitcoin
[16:10:58]W:	 [Step 1/2] + TEST_BITCOIN_JUNIT=junit_results_unit_tests_without_wallet.xml
[16:10:58]W:	 [Step 1/2] + TEST_BITCOIN_SUITE_NAME='Bitcoin ABC unit tests without wallet'
[16:10:58]W:	 [Step 1/2] + ./src/test/test_bitcoin --logger=HRF:JUNIT,message,junit_results_unit_tests_without_wallet.xml -- '-testsuitename=Bitcoin ABC unit tests without wallet'
[16:12:46] :	 [Step 1/2] Running 426 test cases...
[16:12:46] :	 [Step 1/2] 
[16:12:46] :	 [Step 1/2] Assertion occurred in a following context:
[16:12:46] :	 [Step 1/2]     ../src/test/sigcheckcount_tests.cpp:341
[16:12:46] :	 [Step 1/2] Assertion occurred in a following context:
[16:12:46] :	 [Step 1/2]     ../src/test/sigcheckcount_tests.cpp:341
[16:12:46] :	 [Step 1/2] Assertion occurred in a following context:
[16:12:46] :	 [Step 1/2]     ../src/test/sigcheckcount_tests.cpp:341
[16:12:46] :	 [Step 1/2] Assertion occurred in a following context:
[16:12:46] :	 [Step 1/2]     ../src/test/sigcheckcount_tests.cpp:341
[16:12:46] :	 [Step 1/2] Assertion occurred in a following context:
[16:12:46] :	 [Step 1/2]     ../src/test/sigcheckcount_tests.cpp:345
[16:12:46] :	 [Step 1/2] Assertion occurred in a following context:
[16:12:46] :	 [Step 1/2]     ../src/test/sigcheckcount_tests.cpp:345
[16:12:46] :	 [Step 1/2] Assertion occurred in a following context:
[16:12:46] :	 [Step 1/2]     ../src/test/sigcheckcount_tests.cpp:345
[16:12:46] :	 [Step 1/2] Assertion occurred in a following context:
[16:12:46] :	 [Step 1/2]     ../src/test/sigcheckcount_tests.cpp:345
[16:12:46] :	 [Step 1/2] Assertion occurred in a following context:
[16:12:46] :	 [Step 1/2]     ../src/test/sigcheckcount_tests.cpp:355
[16:12:46] :	 [Step 1/2] Assertion occurred in a following context:
[16:12:46] :	 [Step 1/2]     ../src/test/sigcheckcount_tests.cpp:355
[16:12:46] :	 [Step 1/2] Assertion occurred in a following context:
[16:12:46] :	 [Step 1/2]     ../src/test/sigcheckcount_tests.cpp:355
[16:12:46] :	 [Step 1/2] Assertion occurred in a following context:
[16:12:46] :	 [Step 1/2]     ../src/test/sigcheckcount_tests.cpp:355
[16:12:46] :	 [Step 1/2] Assertion occurred in a following context:
[16:12:46] :	 [Step 1/2]     ../src/test/sigcheckcount_tests.cpp:365
[16:12:46] :	 [Step 1/2] Assertion occurred in a following context:
[16:12:46] :	 [Step 1/2]     ../src/test/sigcheckcount_tests.cpp:365
[16:12:46] :	 [Step 1/2] Assertion occurred in a following context:
[16:12:46] :	 [Step 1/2]     ../src/test/sigcheckcount_tests.cpp:365
[16:12:46] :	 [Step 1/2] Assertion occurred in a following context:
[16:12:55]W:	 [Step 1/2] 
[16:12:55]W:	 [Step 1/2]  [1;32;49m*** No errors detected
[16:12:56]W:	 [Step 1/2]  [0;39;49mcp: cannot stat '/work/ibd/debug.log': No such file or directory
[16:12:58] :	 [Step 1/2]     ../src/test/sigcheckcount_tests.cpp:365
[16:12:58]W:	 [Step 1/2] Process exited with code 1
[16:12:58]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)

Snippet of first build failure:

[16:17:59] :	 [Step 1/2]  [0m [0;34mp2p_node_network_limited.py                   | ✓ Passed  | 8 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mp2p_sendheaders.py                            | ✓ Passed  | 12 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mp2p_unrequested_blocks.py                     | ✓ Passed  | 2 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mrpc_bind.py                                   | ✓ Passed  | 35 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mrpc_blockchain.py                             | ✓ Passed  | 6 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mrpc_createmultisig.py                         | ✓ Passed  | 2 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mrpc_decodescript.py                           | ✓ Passed  | 0 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mrpc_deprecated.py                             | ✓ Passed  | 0 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mrpc_estimatefee.py                            | ✓ Passed  | 0 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mrpc_fundrawtransaction.py                     | ✓ Passed  | 30 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mrpc_getblockstats.py                          | ✓ Passed  | 1 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mrpc_getchaintips.py                           | ✓ Passed  | 2 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mrpc_help.py                                   | ✓ Passed  | 0 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mrpc_invalidateblock.py                        | ✓ Passed  | 5 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mrpc_misc.py                                   | ✓ Passed  | 0 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mrpc_named_arguments.py                        | ✓ Passed  | 0 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mrpc_net.py                                    | ✓ Passed  | 1 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mrpc_preciousblock.py                          | ✓ Passed  | 1 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mrpc_psbt.py                                   | ✓ Passed  | 8 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mrpc_rawtransaction.py                         | ✓ Passed  | 25 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mrpc_scantxoutset.py                           | ✓ Passed  | 3 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mrpc_signmessage.py                            | ✓ Passed  | 0 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mrpc_signrawtransaction.py                     | ✓ Passed  | 1 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mrpc_txoutproof.py                             | ✓ Passed  | 2 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mrpc_uptime.py                                 | ✓ Passed  | 0 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mrpc_users.py                                  | ✓ Passed  | 2 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mwallet_abandonconflict.py                     | ✓ Passed  | 8 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mwallet_basic.py                               | ✓ Passed  | 23 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mwallet_create_tx.py                           | ✓ Passed  | 0 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mwallet_createwallet.py                        | ✓ Passed  | 1 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mwallet_createwallet.py --usecli               | ✓ Passed  | 1 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mwallet_disable.py                             | ✓ Passed  | 0 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mwallet_dump.py                                | ✓ Passed  | 2 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mwallet_encryption.py                          | ✓ Passed  | 5 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mwallet_groups.py                              | ✓ Passed  | 9 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mwallet_hd.py                                  | ✓ Passed  | 4 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mwallet_import_rescan.py                       | ✓ Passed  | 3 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mwallet_importmulti.py                         | ✓ Passed  | 2 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mwallet_importprunedfunds.py                   | ✓ Passed  | 0 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mwallet_keypool.py                             | ✓ Passed  | 3 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mwallet_keypool_topup.py                       | ✓ Passed  | 2 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mwallet_labels.py                              | ✓ Passed  | 1 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mwallet_listreceivedby.py                      | ✓ Passed  | 18 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mwallet_listsinceblock.py                      | ✓ Passed  | 2 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mwallet_listtransactions.py                    | ✓ Passed  | 14 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mwallet_multiwallet.py                         | ✓ Passed  | 10 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mwallet_multiwallet.py --usecli                | ✓ Passed  | 11 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mwallet_resendwallettransactions.py            | ✓ Passed  | 1 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mwallet_txn_clone.py                           | ✓ Passed  | 2 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mwallet_txn_clone.py --mineblock               | ✓ Passed  | 2 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mwallet_txn_doublespend.py                     | ✓ Passed  | 2 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mwallet_txn_doublespend.py --mineblock         | ✓ Passed  | 2 s
[16:17:59] :	 [Step 1/2]  [0m [0;34mwallet_zapwallettxes.py                       | ✓ Passed  | 3 s
[16:17:59] :	 [Step 1/2]  [0m [1m
[16:17:59] :	 [Step 1/2] ALL                                           | ✓ Passed  | 535 s (accumulated) 
[16:17:59] :	 [Step 1/2]  [0mRuntime: 119 s
[16:17:59] :	 [Step 1/2] 
[16:18:02]W:	 [Step 1/2] cp: cannot stat '/work/ibd/debug.log': No such file or directory
[16:18:04]W:	 [Step 1/2] Process exited with code 1
[16:18:04]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)
This revision is now accepted and ready to land.Apr 8 2020, 16:30