[CMAKE] Allow to override the optimization level
AbandonedPublic
Actions

Authored by Fabien on Apr 13 2020, 12:04.

Details

Reviewers

Group Reviewers

Restricted Project

Summary

This adds a few facilities to change the optimization level that will be
used when running for coverage. Unused at the moment, and split to make
the review easier.

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmake_set_optimization

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10182
Build 18190: Default Diff Build & Tests
Build 18189: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 13 2020, 12:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 13 2020, 12:04

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien added a child revision: D5321: [CMAKE] Add support for generating test coverage reports.Apr 13 2020, 12:09

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10182: Diff 18751.Apr 13 2020, 12:15

Test plan clearly doesn't test the code. In fact this patch introduce dead code.

This revision now requires changes to proceed.Apr 13 2020, 13:17

Will squash with D5321

Fabien mentioned this in D5321: [CMAKE] Add support for generating test coverage reports.Apr 13 2020, 13:23

Fabien removed a child revision: D5321: [CMAKE] Add support for generating test coverage reports.

Fabien abandoned this revision.Apr 13 2020, 13:27

Revision Contents
Changeset List

Path

Size

cmake/

modules/

AddCompilerFlags.cmake

28 lines

Diff 18751

View Options

cmake/modules/AddCompilerFlags.cmake

[CMAKE] Allow to override the optimization levelAbandonedPublicActions