Page MenuHomePhabricator
Differential D5718

Move PSBT definitions and code to separate files
ClosedPublic
Actions

Authored by Fabien on Apr 13 2020, 20:08.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING2f3cc194c824: Move PSBT definitions and code to separate files
rABC2f3cc194c824: Move PSBT definitions and code to separate files
Summary
Move non-wallet PSBT code to src/psbt.{h,cpp}, and PSBT wallet code to
src/wallet/psbtwallet.{h,cpp}. This commit contains only code movement
(and adjustments to includes and Makefile.am.)

Partial backport of core PR14978:
https://github.com/bitcoin/bitcoin/pull/14978/commits/c6c3d42a7d6b525144fc7fc6653cd11139d2b34a

Depends on D5715.

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14978_part2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10201
Build 18227: Default Diff Build & Tests
Build 18226: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 13 2020, 20:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 13 2020, 20:08
teamcity edited the summary of this revision. (Show Details)Apr 13 2020, 20:08

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 13 2020, 20:08

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 13 2020, 20:20

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10201: Diff 18777.Apr 13 2020, 20:20
deadalnix accepted this revision.Apr 13 2020, 22:55
This revision is now accepted and ready to land.Apr 13 2020, 22:55
Closed by commit rABC2f3cc194c824: Move PSBT definitions and code to separate files (authored by Glenn Willen <gwillen@nerdnet.org>, committed by Fabien). · Explain WhyApr 15 2020, 10:54
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC2f3cc194c824: Move PSBT definitions and code to separate files.
Fabien added a commit: rSTAGING2f3cc194c824: Move PSBT definitions and code to separate files.May 5 2020, 18:58

Revision Contents
Changeset List

PathSize
src/
1 line
4 lines
1 line
psbt.h/
script/
sign.h
242 lines
171 lines
rpc/
1 line
script/
472 lines
165 lines
wallet/
1 line
16 lines
70 lines
3 lines
64 lines
test/
1 line

Diff 18777

View Options

src/CMakeLists.txt

Loading...
View Options

src/Makefile.am

Loading...
View Options

src/core_read.cpp

Loading...
View Options

src/psbt.h

Loading...
View Options

src/psbt.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/script/sign.h

Loading...
View Options

src/script/sign.cpp

Loading...
View Options

src/wallet/CMakeLists.txt

Loading...
View Options

src/wallet/psbtwallet.h

Loading...
View Options

src/wallet/psbtwallet.cpp

Loading...
View Options

src/wallet/rpcwallet.h

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/test/psbt_wallet_tests.cpp

Loading...