Page MenuHomePhabricator
Differential D5763

[cmake] Fix dependencies for functional test targets
ClosedPublic
Actions

Authored by deadalnix on Apr 17 2020, 16:16.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING5713adbef822: [cmake] Fix dependencies for functional test targets
rABC5713adbef822: [cmake] Fix dependencies for functional test targets
Summary

They are wrong :)

Test Plan

On master:

ninja clean
ninja check-functional

Fails because bitcoin-wallet is not built.

With this patch:

ninja check-functional

Works.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fixfundep
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10278
Build 18378: Default Diff Build & Tests
Build 18377: arc lint + arc unit

Event Timeline

deadalnix created this revision.Apr 17 2020, 16:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 17 2020, 16:16
teamcity added a comment.Apr 17 2020, 16:18

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien accepted this revision.Apr 17 2020, 16:49
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/CMakeLists.txt
58

You can set to bitcoind ${CMAKE_CURRENT_BINARY_DIR}/functional/test_runner.py so all the dependencies are here at the same place.

This revision is now accepted and ready to land.Apr 17 2020, 16:49
teamcity added a comment.Apr 17 2020, 16:53

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10278: Diff 18915.Apr 17 2020, 16:53
Closed by commit rABC5713adbef822: [cmake] Fix dependencies for functional test targets (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by deadalnix). · Explain WhyApr 18 2020, 06:53
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC5713adbef822: [cmake] Fix dependencies for functional test targets.
deadalnix added a commit: rSTAGING5713adbef822: [cmake] Fix dependencies for functional test targets.May 5 2020, 19:01

Revision Contents
Changeset List

PathSize
src/
2 lines
test/
11 lines

Diff 18915

View Options

src/CMakeLists.txt

Loading...
View Options

test/CMakeLists.txt

Loading...