Paths

Table of Contentst

Differential D5791

Merge #17068: qt: Always generate `bitcoinstrings.cpp` on `make translate`
ClosedPublic
Actions

Authored by jasonbcox on Apr 21 2020, 00:13.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGa39dd3235283: Merge #17068: qt: Always generate `bitcoinstrings.cpp` on `make translate`
rABCa39dd3235283: Merge #17068: qt: Always generate `bitcoinstrings.cpp` on `make translate`

Summary

c640ca24f9d94f468ec6de023bf885813ac6c9a9 Always generate bitcoinstrings.cpp on make translate (Franck Royer)

Pull request description:

Resolves #16891.

`bitcoinstrings.cpp` is to be generated at release time. Hence,
it should not depend on whether the source files are younger as the
releaser may proceed from a fresh checkout.

More information on the investigation in the issue.

ACKs for top commit:

jonasschnelli:
  Tested ACK c640ca24f9d94f468ec6de023bf885813ac6c9a9 - Tested master + this on macOS 10.14. With this PR, it always "runs" `GEN      qt/bitcoinstrings.cpp` and `GEN      translate`.

Tree-SHA512: f799fdc3ad16a2a6a59704bc2c50f5179e6a7e064d8f43354592f11857cc901cac99b2b90f3319d25d49c9d78378b8d119cc5f59b48ea7f1008f33dd26700877

Backport of Core PR17068

According to the PR discussion, this issue may affect make translate on MacOS and Ubuntu.

Reviewer note: This is out of order, as PR16291 should ideally come first. But I don't want to tackle that backport
at this time.

Depends on D5790 for the test plan.

Test Plan

../configure
make -j8
cd src
make translate
arc lint

Not committed with this patch, but there should be some sane output in bitcoinstrings.cpp

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr17068

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10323
Build 18467: Default Diff Build & Tests
Build 18466: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 21 2020, 00:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 21 2020, 00:13

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

jasonbcox edited the summary of this revision. (Show Details)Apr 21 2020, 00:14

jasonbcox added a parent revision: D5790: core -> ABC in extract_strings_qt.py.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10323: Diff 18984.Apr 21 2020, 00:23

deadalnix edited the summary of this revision. (Show Details)Apr 21 2020, 00:25

deadalnix edited the summary of this revision. (Show Details)

deadalnix accepted this revision.Apr 21 2020, 00:33

This revision is now accepted and ready to land.Apr 21 2020, 00:33

jasonbcox mentioned this in D5792: Mark translation files as @generated and update them.Apr 21 2020, 00:36

jasonbcox added a child revision: D5792: Mark translation files as @generated and update them.Apr 21 2020, 00:36

Closed by commit rABCa39dd3235283: Merge #17068: qt: Always generate `bitcoinstrings.cpp` on `make translate` (authored by Wladimir J. van der Laan <laanwj@protonmail.com>, committed by jasonbcox). · Explain WhyApr 21 2020, 00:42

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABCa39dd3235283: Merge #17068: qt: Always generate `bitcoinstrings.cpp` on `make translate`.

jasonbcox mentioned this in D5790: core -> ABC in extract_strings_qt.py.Apr 21 2020, 00:44

jasonbcox added a commit: rSTAGINGa39dd3235283: Merge #17068: qt: Always generate `bitcoinstrings.cpp` on `make translate`.May 5 2020, 19:03

Revision Contents
Changeset List

Path

Size

src/

Makefile.qt.include

4 lines

Diff 18984

View Options

Merge #17068: qt: Always generate `bitcoinstrings.cpp` on `make translate`ClosedPublicActions