Page MenuHomePhabricator
Differential D5946

Update confusing names in rpc_blockchain.py
ClosedPublic
Actions

Authored by deadalnix on May 4 2020, 00:07.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGf6ccacf58229: Update confusing names in rpc_blockchain.py
rABCf6ccacf58229: Update confusing names in rpc_blockchain.py
Summary

As per title. Name convention is absolutely confusing.

Test Plan
./test/functional/test_runner.py rpc_blockchain.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
_test_getblock_refac
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10568
Build 18947: Default Diff Build & Tests
Build 18946: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 4 2020, 00:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 4 2020, 00:07
teamcity added a comment.May 4 2020, 00:08

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 4 2020, 00:16

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10567: Diff 19392.May 4 2020, 00:16
deadalnix requested review of this revision.May 4 2020, 00:16
deadalnix updated this revision to Diff 19393.May 4 2020, 00:39

Reodrder functions to reflect execution order

teamcity added a comment.May 4 2020, 00:40

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 4 2020, 00:48

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10568: Diff 19393.May 4 2020, 00:48
Fabien accepted this revision.May 4 2020, 07:04
This revision is now accepted and ready to land.May 4 2020, 07:04
Closed by commit rABCf6ccacf58229: Update confusing names in rpc_blockchain.py (authored by deadalnix). · Explain WhyMay 4 2020, 13:07
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCf6ccacf58229: Update confusing names in rpc_blockchain.py.
deadalnix added a commit: rSTAGINGf6ccacf58229: Update confusing names in rpc_blockchain.py.May 5 2020, 19:18

Revision Contents
Changeset List

PathSize
test/
functional/
68 lines

Diff 19393

View Options

test/functional/rpc_blockchain.py

Loading...