Page MenuHomePhabricator
Differential D5981

Merge #16267: bench: Benchmark blockToJSON
ClosedPublic
Actions

Authored by jasonbcox on May 6 2020, 17:30.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING2e7115ee284e: Merge #16267: bench: Benchmark blockToJSON
rABC2e7115ee284e: Merge #16267: bench: Benchmark blockToJSON
Summary

91509ffe247b0eacbf84214c7c9c3f8a0012f2eb bench: Benchmark blockToJSON (Kirill Fomichev)

Pull request description:

Related:
- "getblock performance issue on verbosity" https://github.com/bitcoin/bitcoin/issues/15925
- "refactor: Avoid UniValue copy constructor" #15974

ACKs for top commit:

laanwj:
  ACK 91509ffe247b0eacbf84214c7c9c3f8a0012f2eb

Tree-SHA512: e70b12cb31921c7527bde334f52f39776da698b6bbdb196079a8b68478c67585a5bd7bed7403f65166bd604f7ed60778c53dc064d743bb8368318a1283d1073e

Backport of Core PR16267

Also cleans up the includes per Core PR16659

Depends on D5980

Test Plan
ninja check
ninja src/bench/bitcoin-bench
./src/bench/bitcoin-bench -filter=BlockToJsonVerbose

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr16267
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10616
Build 19041: Default Diff Build & Tests
Build 19040: arc lint + arc unit

Event Timeline

jasonbcox created this revision.May 6 2020, 17:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 6 2020, 17:30
jasonbcox requested review of this revision.May 6 2020, 17:30
teamcity edited the summary of this revision. (Show Details)May 6 2020, 17:30

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 6 2020, 17:31

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

jasonbcox added a child revision: D5982: UniValue performance speedups for .write().May 6 2020, 17:37
teamcity added a comment.May 6 2020, 17:42

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10616: Diff 19753.May 6 2020, 17:42
deadalnix accepted this revision.May 6 2020, 18:24
This revision is now accepted and ready to land.May 6 2020, 18:24
Closed by commit rABC2e7115ee284e: Merge #16267: bench: Benchmark blockToJSON (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyMay 6 2020, 19:00
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC2e7115ee284e: Merge #16267: bench: Benchmark blockToJSON.
jasonbcox added a commit: rSTAGING2e7115ee284e: Merge #16267: bench: Benchmark blockToJSON.May 6 2020, 19:05

Revision Contents
Changeset List

PathSize
src/
1 line
bench/
1 line
34 lines

Diff 19753

View Options

src/Makefile.bench.include

Loading...
View Options

src/bench/CMakeLists.txt

Loading...
View Options

src/bench/rpc_blockchain.cpp

Loading...