Page MenuHomePhabricator
Differential D6112

[backport#15153] gui: Add openWallet and getWalletsAvailableToOpen to WalletController
ClosedPublic
Actions

Authored by majcosta on May 18 2020, 13:53.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING39153d2e62e9: [backport#15153] gui: Add openWallet and getWalletsAvailableToOpen to…
rABC39153d2e62e9: [backport#15153] gui: Add openWallet and getWalletsAvailableToOpen to…
Summary

https://github.com/bitcoin/bitcoin/pull/15153/commits/32a8c6abfe32d5b89bf4505ca8397bdb44867614

This is a partial backport of Core PR15153

Test Plan
ninja check

Diff Detail

Event Timeline

majcosta created this revision.May 18 2020, 13:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 18 2020, 13:53
majcosta requested review of this revision.May 18 2020, 13:53
teamcity edited the summary of this revision. (Show Details)May 18 2020, 13:53

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 18 2020, 13:54

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 18 2020, 13:55

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 18 2020, 13:56

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 18 2020, 13:56

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 18 2020, 14:00

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 18 2020, 14:07

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10819: Diff 20196.May 18 2020, 14:07
deadalnix requested changes to this revision.May 18 2020, 14:19
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/qt/walletcontroller.cpp
48 ↗(On Diff #20196)

braces

This revision now requires changes to proceed.May 18 2020, 14:19
majcosta updated this revision to Diff 20207.May 18 2020, 14:54

added missing braces around if statement

teamcity added a comment.May 18 2020, 15:08

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 18 2020, 15:08

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 18 2020, 15:09

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 18 2020, 15:10

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 18 2020, 15:12

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

deadalnix accepted this revision.May 18 2020, 15:16
This revision is now accepted and ready to land.May 18 2020, 15:16
teamcity added a comment.May 18 2020, 15:19

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10822: Diff 20207.May 18 2020, 15:19
Closed by commit rABC39153d2e62e9: [backport#15153] gui: Add openWallet and getWalletsAvailableToOpen to… (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by majcosta). · Explain WhyMay 18 2020, 16:59
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC39153d2e62e9: [backport#15153] gui: Add openWallet and getWalletsAvailableToOpen to….
majcosta added a commit: rSTAGING39153d2e62e9: [backport#15153] gui: Add openWallet and getWalletsAvailableToOpen to….May 18 2020, 17:05

Revision Contents
Changeset List

PathSize
src/
qt/
4 lines
30 lines

Diff 20207

View Options

src/qt/walletcontroller.h

Loading...
View Options

src/qt/walletcontroller.cpp

Loading...