Page MenuHomePhabricator
Differential D6139

Add RNG strengthening (10ms once every minute)
ClosedPublic
Actions

Authored by Fabien on May 19 2020, 13:37.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGfd5dffcbe588: Add RNG strengthening (10ms once every minute)
rABCfd5dffcbe588: Add RNG strengthening (10ms once every minute)
Summary
This patch improves the built-in RNG using hash strengthening.

At startup, and once every minute, 32 bytes of entropy are produced from
the RNG, repeatedly hashed using SHA512 for 10ms, and then fed back into
the RNG, together with high-precision timestamps obtained every 1000
iterations.

Backport of core PR15224.

Test Plan
ninja all check-all

Diff Detail

Event Timeline

Fabien created this revision.May 19 2020, 13:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 19 2020, 13:37
Fabien requested review of this revision.May 19 2020, 13:37
teamcity edited the summary of this revision. (Show Details)May 19 2020, 13:38

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 19 2020, 13:39

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 19 2020, 13:42

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 19 2020, 13:42

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 19 2020, 13:43

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 19 2020, 13:47

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 19 2020, 13:56

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10854: Diff 20269.May 19 2020, 13:56
deadalnix accepted this revision.May 19 2020, 14:58
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/random.h
52

There is a line break missing between the two sentences.

This revision is now accepted and ready to land.May 19 2020, 14:58
Fabien updated this revision to Diff 20277.May 19 2020, 15:36

Newline in comment

teamcity added a comment.May 19 2020, 15:37

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 19 2020, 15:37

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 19 2020, 15:37

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

This revision was landed with ongoing or failed builds.May 19 2020, 15:37
Closed by commit rABCfd5dffcbe588: Add RNG strengthening (10ms once every minute) (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by Fabien). · Explain Why
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCfd5dffcbe588: Add RNG strengthening (10ms once every minute).
Fabien added a commit: rSTAGINGfd5dffcbe588: Add RNG strengthening (10ms once every minute).May 19 2020, 15:40
teamcity added a comment.May 19 2020, 15:40

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 19 2020, 15:42

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 19 2020, 15:49

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10856: Diff 20277.May 19 2020, 15:49

Revision Contents
Changeset List

PathSize
src/
7 lines
63 lines

Diff 20269

View Options

src/random.h

Loading...
View Options

src/random.cpp

Loading...