random: remove call to RAND_screen() (Windows only)
ClosedPublic
Actions

Authored by Fabien on May 20 2020, 11:21.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING887a72c4c04a: random: remove call to RAND_screen() (Windows only)
rABC887a72c4c04a: random: remove call to RAND_screen() (Windows only)

Summary

Follow up to https://github.com/bitcoin/bitcoin/pull/17151 where
there were multiple calls to also remove our call to RAND_screen().

Backport of core PR17191.

Test Plan

Run the build-win64 CI build plan.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR17191

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10882
Build 19806: Default Diff Build & Tests
Build 19805: Build without Wallet
Build 19804: Build with clang-10
Build 19803: arc lint + arc unit

Event Timeline

Fabien created this revision.May 20 2020, 11:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2020, 11:21

Fabien requested review of this revision.May 20 2020, 11:21

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing (build-win64) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10882: Diff 20326.May 20 2020, 11:31

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing (build-win64) passed.

deadalnix accepted this revision.May 20 2020, 11:32

This revision is now accepted and ready to land.May 20 2020, 11:32

Fabien added a child revision: D6158: doc: minor corrections in random.cpp.May 20 2020, 11:35

Closed by commit rABC887a72c4c04a: random: remove call to RAND_screen() (Windows only) (authored by fanquake <fanquake@gmail.com>, committed by Fabien). · Explain WhyMay 20 2020, 12:27

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC887a72c4c04a: random: remove call to RAND_screen() (Windows only).

Fabien added a commit: rSTAGING887a72c4c04a: random: remove call to RAND_screen() (Windows only).May 20 2020, 12:30

Revision Contents
Changeset List

Path

Size

src/

random.cpp

4 lines

Diff 20326

View Options

random: remove call to RAND_screen() (Windows only)ClosedPublicActions