Page MenuHomePhabricator
Differential D6274

Fix shadow warning
ClosedPublic
Actions

Authored by Fabien on May 28 2020, 09:07.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCba85dd611645: Fix shadow warning
Summary

The blockparams parameter of the lambda function shadows the
blockparams locale variable from FindEarliestAtLeast according to
GCC.

Test Plan

With GCC as a compiler (tested with GCC 10.1):

cmake -GNInja .. -DCMAKE_CXX_FLAGS=Werror=shadow
ninja

Check the warning is gone.

Diff Detail

Event Timeline

Fabien created this revision.May 28 2020, 09:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 28 2020, 09:07
Fabien requested review of this revision.May 28 2020, 09:07
teamcity added a comment.May 28 2020, 09:07

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 28 2020, 09:08

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 28 2020, 09:08

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 28 2020, 09:10

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 28 2020, 09:13

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 28 2020, 09:20

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11059: Diff 20658.May 28 2020, 09:21
deadalnix accepted this revision.May 28 2020, 12:26
This revision is now accepted and ready to land.May 28 2020, 12:26
Closed by commit rABCba85dd611645: Fix shadow warning (authored by Fabien). · Explain WhyMay 28 2020, 12:47
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCba85dd611645: Fix shadow warning.

Revision Contents
Changeset List

PathSize
src/
6 lines

Diff 20658

View Options

src/chain.cpp

Loading...