Page MenuHomePhabricator
Differential D6299

Fix WSL file locking by using flock instead of fcntl
ClosedPublic
Actions

Authored by nakihito on May 29 2020, 19:36.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC5cf3c08e993d: Fix WSL file locking by using flock instead of fcntl
Summary

Co-authored-by: sipa <pieter@wuille.net>

Backport of Core PR18700

Test Plan

On WSL

ninja check
ninja check-functional

Confirm all tests pass except feature_proxy.py (fails), rpc_bind.py (skipped), and interface_zmq.py (skipped).

Using two different consoles:

src/bitcoind

Verify this fails on the second console with the following error:

Error: Cannot obtain a lock on data directory <path>/.bitcoin. Bitcoin ABC is probably already running.

Diff Detail

Event Timeline

nakihito created this revision.May 29 2020, 19:36
Owners added a reviewer: Restricted Owners Package.May 29 2020, 19:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 29 2020, 19:36
nakihito requested review of this revision.May 29 2020, 19:36
teamcity edited the summary of this revision. (Show Details)May 29 2020, 19:36

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 29 2020, 19:36

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 29 2020, 19:36

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 29 2020, 19:36

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 29 2020, 19:37

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 29 2020, 19:40

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

nakihito edited the test plan for this revision. (Show Details)May 29 2020, 19:41
teamcity added a comment.May 29 2020, 19:46

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11092: Diff 20713.May 29 2020, 19:46
jasonbcox accepted this revision.May 29 2020, 20:19
This revision is now accepted and ready to land.May 29 2020, 20:19
Closed by commit rABC5cf3c08e993d: Fix WSL file locking by using flock instead of fcntl (authored by Samuel Dobson <dobsonsa68@gmail.com>, committed by nakihito). · Explain WhyMay 29 2020, 20:39
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC5cf3c08e993d: Fix WSL file locking by using flock instead of fcntl.

Revision Contents
Changeset List

PathSize
src/
38 lines

Diff 20713

View Options

src/fs.cpp

Loading...