Fix Debian package script in case signer has multiple user IDs
ClosedPublic
Actions

Authored by jasonbcox on Jun 2 2020, 19:12.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCf7541c92b9fe: Fix Debian package script in case signer has multiple user IDs

Summary

The script breaks if the signer has multiple, ultimately-trusted user IDs.
I recently added another email to my GPG key, so this was broken for me.

Test Plan

Used this script to upload to my staging PPA: https://launchpad.net/~jasonbcox/+archive/ubuntu/bitcoin-abc/+packages
./debian-packages.sh -p jasonbcox-bitcoin-abc jasonbcox

Diff Detail

Repository

rABC Bitcoin ABC

Branch

release-signer

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11146
Build 20841: Default Diff Build & Tests
Build 20840: Build without Wallet
Build 20839: Build with clang-10
Build 20838: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jun 2 2020, 19:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 2 2020, 19:12

jasonbcox requested review of this revision.Jun 2 2020, 19:12

jasonbcox edited the test plan for this revision. (Show Details)Jun 2 2020, 19:12

Harbormaster completed remote builds in B11144: Diff 20805.Jun 2 2020, 19:31

Fabien added a subscriber: Fabien.Jun 2 2020, 19:54

Fabien added inline comments.

contrib/release/debian-packages.sh
111 ↗	(On Diff #20805)	I don't see the point, you already know the signer email since it's in the keys.txt file. You can use it to filter with no ambiguity.

jasonbcox planned changes to this revision.Jun 2 2020, 19:58

Use email from keys.txt

jasonbcox retitled this revision from Fix Debian package script to support multiple user IDs from a single signer to Fix Debian package script in case signer has multiple user IDs.Jun 2 2020, 20:14

Fabien accepted this revision.Jun 2 2020, 20:20

This revision is now accepted and ready to land.Jun 2 2020, 20:20

Harbormaster completed remote builds in B11146: Diff 20807.Jun 2 2020, 20:32

Closed by commit rABCf7541c92b9fe: Fix Debian package script in case signer has multiple user IDs (authored by jasonbcox). · Explain WhyJun 3 2020, 00:30

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABCf7541c92b9fe: Fix Debian package script in case signer has multiple user IDs.