Page MenuHomePhabricator
Differential D6381

Improve handling of INVALID in IsMine
ClosedPublic
Actions

Authored by deadalnix on Jun 5 2020, 01:06.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC71905e7247f9: Improve handling of INVALID in IsMine
Summary
  • Do not expose invalidity from IsMine
  • Add additional unit tests for invalid IsMine combinations
  • Add P2WSH destination helper and use it instead of manual hashing

This is a backport of Core PR13491

Test Plan
ninja all check-all

Diff Detail

Event Timeline

deadalnix created this revision.Jun 5 2020, 01:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 5 2020, 01:07
deadalnix requested review of this revision.Jun 5 2020, 01:07
teamcity edited the summary of this revision. (Show Details)Jun 5 2020, 01:07

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11220: Diff 20932.Jun 5 2020, 01:21
majcosta accepted this revision.Jun 5 2020, 01:51
This revision is now accepted and ready to land.Jun 5 2020, 01:51
Closed by commit rABC71905e7247f9: Improve handling of INVALID in IsMine (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyJun 5 2020, 08:16
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC71905e7247f9: Improve handling of INVALID in IsMine.

Revision Contents
Changeset List

PathSize
src/
script/
9 lines
12 lines
1 line
test/
115 lines

Diff 20932

View Options

src/script/ismine.h

Loading...
View Options

src/script/ismine.cpp

Loading...
View Options

src/script/standard.cpp

Loading...
View Options

src/test/script_standard_tests.cpp

Loading...