Page MenuHomePhabricator
Differential D6394

Merge #15246: qa: Add tests for invalid message headers
ClosedPublic
Actions

Authored by jasonbcox on Jun 5 2020, 20:26.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC705b3c6c8cca: Merge #15246: qa: Add tests for invalid message headers
Summary

fa3745bda84d5b3a26fdf8af4ac44d6088e11eee qa: Add tests for invalid message headers (MarcoFalke)

Pull request description:

Tree-SHA512: b37e297cfd65a33a7af201f750a303cf437b438e40d38b1d2f562ccde67082616daa110ca1e5e3af6514ea4ca4b115362acf2ffa6263cea3c8e8189ce02dda67

Backport of Core PR15246

Test Plan

ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jun 5 2020, 20:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 5 2020, 20:26
jasonbcox requested review of this revision.Jun 5 2020, 20:26
teamcity edited the summary of this revision. (Show Details)Jun 5 2020, 20:26

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

jasonbcox added inline comments.Jun 5 2020, 20:27
test/functional/p2p_invalid_messages.py
168 ↗(On Diff #20958)

Reviewer note: this line differs because we ban for this behavior. See D2289

Harbormaster completed remote builds in B11237: Diff 20958.Jun 5 2020, 20:36
deadalnix accepted this revision.Jun 5 2020, 20:52
This revision is now accepted and ready to land.Jun 5 2020, 20:52
Closed by commit rABC705b3c6c8cca: Merge #15246: qa: Add tests for invalid message headers (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyJun 5 2020, 21:36
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC705b3c6c8cca: Merge #15246: qa: Add tests for invalid message headers.

Revision Contents
Changeset List

PathSize
test/
functional/
3 lines
86 lines
test_framework/
6 lines

Diff 20963

View Options

test/functional/abc-invalid-message.py

Loading...
View Options

test/functional/p2p_invalid_messages.py

Loading...
View Options

test/functional/test_framework/mininode.py

Loading...