Differential D6421

[backport#15713 3/5] Remove duplicate checks in SubmitMemoryPoolAndRelay
ClosedPublic
Actions

Authored by majcosta on Jun 6 2020, 22:24.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC552ce234fb05: [backport#15713 3/5] Remove duplicate checks in SubmitMemoryPoolAndRelay

Summary

IsCoinBase check is already performed early by
AcceptToMemoryPoolWorker
GetDepthInMainChain check is already perfomed by
BroadcastTransaction

To avoid deadlock we MUST keep lock order in
ResendWalletTransactions and CommitTransaction,
even if we lock cs_main again further.
in BroadcastTransaction. Lock order will need
to be clean at once in a future refactoring

https://github.com/bitcoin/bitcoin/pull/15713/commits/8753f5652b4710e66b50ce87788bf6f33619b75a

Depends on D6420

Partial backport of Core PR15713

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11270
Build 21319: Default Diff Build & Tests
Build 21318: Build without Wallet
Build 21317: Build with clang-10
Build 21316: arc lint + arc unit

Event Timeline

majcosta created this revision.Jun 6 2020, 22:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 6 2020, 22:24

majcosta requested review of this revision.Jun 6 2020, 22:24

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11270: Diff 21007.Jun 6 2020, 22:33

The patch doesn't seems to be the one in the description.

This revision now requires changes to proceed.Jun 6 2020, 22:35

fat fingers, my bad

majcosta retitled this revision from [backport#15713] Remove duplicate checks in SubmitMemoryPoolAndRelay to [backport#15713 3/5] Remove duplicate checks in SubmitMemoryPoolAndRelay.Jun 6 2020, 22:56

majcosta added a child revision: D6422: [backport#15713 4/5] Remove unused submitToMemoryPool and relayTransactions Chain interfaces.

deadalnix accepted this revision.Jun 6 2020, 23:17

This revision is now accepted and ready to land.Jun 6 2020, 23:17

Closed by commit rABC552ce234fb05: [backport#15713 3/5] Remove duplicate checks in SubmitMemoryPoolAndRelay (authored by Antoine Riard <ariard@student.42.fr>, committed by majcosta). · Explain WhyJun 7 2020, 00:38

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC552ce234fb05: [backport#15713 3/5] Remove duplicate checks in SubmitMemoryPoolAndRelay.