Page MenuHomePhabricator

[bugfix] prevent nodes from banning other nodes in ABC tests
ClosedPublic

Authored by majcosta on Jun 8 2020, 18:09.

Details

Summary

Core PR16898 changes the test_framework to use connect_nodes instead of
connect_nodes_bi, this changes the network topology of the tests which
led some of our abc-* tests to fail.

according to the logs nodes were disconnecting the other, these changes
add a -whitelist=noban@127.0.0.1 to prevent them from doing so
allowing the tests to complete

Test Plan
ninja
test_runner.py abc-finalize-block abc-parkedchain

Event Timeline

majcosta requested review of this revision.Jun 8 2020, 18:09

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Jun 8 2020, 20:41