Page MenuHomePhabricator
Differential D6481

Merge #13503: Document FreeBSD quirk. Fix FreeBSD build: Use std::min<int>(...) to allow for compilation under certain FreeBSD versions.
ClosedPublic
Actions

Authored by nakihito on Jun 9 2020, 17:09.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCee323c8b68d7: Merge #13503: Document FreeBSD quirk. Fix FreeBSD build: Use std::min<int>(...)…
Summary

629a47a154 Document FreeBSD quirk. Fix FreeBSD build. (practicalswift)

Pull request description:

Tree-SHA512: 5ca7a5fa9e1f3efae241b9be64c9b019ec713c11dcc3edaaed383477ea48ac0dc82549ffebbe9069e8c3f6eff30acd6e4542b4aa31d307f022f4f51e5851a82c

Backport of Core PR13503

Test Plan
ninja
ninja check-all

Repeat with FreeBSD build.

Diff Detail

Event Timeline

nakihito created this revision.Jun 9 2020, 17:09
Owners added a reviewer: Restricted Owners Package.Jun 9 2020, 17:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 9 2020, 17:09
nakihito requested review of this revision.Jun 9 2020, 17:09
teamcity edited the summary of this revision. (Show Details)Jun 9 2020, 17:09

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11357: Diff 21155.Jun 9 2020, 17:24
nakihito planned changes to this revision.Jun 9 2020, 17:46
nakihito requested review of this revision.Jun 9 2020, 20:09
nakihito edited the test plan for this revision. (Show Details)
Fabien accepted this revision.Jun 9 2020, 20:15
This revision is now accepted and ready to land.Jun 9 2020, 20:15
Closed by commit rABCee323c8b68d7: Merge #13503: Document FreeBSD quirk. Fix FreeBSD build: Use std::min<int>(...)… (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhyJun 9 2020, 20:17
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCee323c8b68d7: Merge #13503: Document FreeBSD quirk. Fix FreeBSD build: Use std::min<int>(...)….

Revision Contents
Changeset List

PathSize
src/
8 lines

Diff 21155

View Options

src/init.cpp

Loading...