Paths

Table of Contentst

Differential D6568

[CI] Fix wrong path to bitcoind binary on build-ibd-*
ClosedPublic
Actions

Authored by Fabien on Jun 15 2020, 09:22.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCe1c4fc1249f5: [CI] Fix wrong path to bitcoind binary on build-ibd-*

Summary

The ibd.sh and bitcoind-exit-on-log.sh scripts were relying on the
default build directory to find the bitcoind binary to run. This is
causing failure since D6551.

Test Plan

Run the ci build-ibd* build plans.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ci_fix_ibd_build_dir

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11473
Build 22043: Default Diff Build & Tests	Link to the build
Build 22042: Build without Wallet	Link to the build
Build 22041: Build with clang-10	Link to the build
Build 22040: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 15 2020, 09:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 15 2020, 09:22

Fabien requested review of this revision.Jun 15 2020, 09:22

Harbormaster completed remote builds in B11473: Diff 21368.Jun 15 2020, 09:43

deadalnix accepted this revision.Jun 15 2020, 13:05

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

contrib/teamcity/ibd.sh
47	This whole approach is fragile. There is a RPC to check for this.

This revision is now accepted and ready to land.Jun 15 2020, 13:05

Closed by commit rABCe1c4fc1249f5: [CI] Fix wrong path to bitcoind binary on build-ibd-* (authored by Fabien). · Explain WhyJun 15 2020, 13:30

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCe1c4fc1249f5: [CI] Fix wrong path to bitcoind binary on build-ibd-*.

Good call

Revision Contents
Changeset List

Path

Size

contrib/

teamcity/

9 lines

Diff 21368

contrib/teamcity/ibd.sh

Loading...