Differential D6570

Consistently use the QT_VERSION_CHECK macro
ClosedPublic
Actions

Authored by Fabien on Jun 15 2020, 10:32.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC1b58d6694721: Consistently use the QT_VERSION_CHECK macro

Summary

We no longer need to remember how the Qt version number is built. It is
also easier to read.

Depends on D6569.

Test Plan

ninja all check

Grepped for QT_VERSION to ensure there is no remaining case.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

qt_version_check

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11475
Build 22051: Default Diff Build & Tests	Link to the build
Build 22050: Build without Wallet	Link to the build
Build 22049: Build with clang-10	Link to the build
Build 22048: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 15 2020, 10:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 15 2020, 10:32

Fabien requested review of this revision.Jun 15 2020, 10:32

Harbormaster completed remote builds in B11475: Diff 21370.Jun 15 2020, 10:45

deadalnix accepted this revision.Jun 15 2020, 13:04

This revision is now accepted and ready to land.Jun 15 2020, 13:04

Closed by commit rABC1b58d6694721: Consistently use the QT_VERSION_CHECK macro (authored by Fabien). · Explain WhyJun 15 2020, 13:32

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC1b58d6694721: Consistently use the QT_VERSION_CHECK macro.

Revision Contents
Changeset List

Path

Size

src/

qt/

bitcoin.cpp

2 lines

Diff 21370

View Options

Consistently use the QT_VERSION_CHECK macroClosedPublicActions