Paths

Table of Contentst

Differential D6573

[Qt] Fix deprecated pixmap() return by pointer with Qt 5.15
ClosedPublic
Actions

Authored by Fabien on Jun 15 2020, 13:29.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCa7a19984d08a: [Qt] Fix deprecated pixmap() return by pointer with Qt 5.15

Summary

The pixmap() method returning a QImage * is deprecated with Qt 5.15.
It is replaced by a new pixmap(Qt::ReturnByValue) call which returns
by value as its name implies.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

qt_pixmap_return_pointer_deprecated

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11479
Build 22067: Default Diff Build & Tests	Link to the build
Build 22066: Build without Wallet	Link to the build
Build 22065: Build with clang-10	Link to the build
Build 22064: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 15 2020, 13:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 15 2020, 13:29

Fabien requested review of this revision.Jun 15 2020, 13:29

I missed one

Add the missed one

Harbormaster completed remote builds in B11478: Diff 21379.Jun 15 2020, 13:59

deadalnix requested changes to this revision.Jun 15 2020, 14:08

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/qt/guiutil.cpp
933	This API is pretty bad. Why not make it `hasPixmap` instead?
src/qt/receiverequestdialog.cpp
56	It looks like this could be factored.

This revision now requires changes to proceed.Jun 15 2020, 14:08

Harbormaster completed remote builds in B11479: Diff 21384.Jun 15 2020, 14:09

Address feedback

Harbormaster completed remote builds in B11482: Diff 21389.Jun 15 2020, 15:08

deadalnix accepted this revision.Jun 15 2020, 15:31

This revision is now accepted and ready to land.Jun 15 2020, 15:31

Closed by commit rABCa7a19984d08a: [Qt] Fix deprecated pixmap() return by pointer with Qt 5.15 (authored by Fabien). · Explain WhyJun 15 2020, 19:12

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCa7a19984d08a: [Qt] Fix deprecated pixmap() return by pointer with Qt 5.15.

Revision Contents
Changeset List

Path

Size

src/

qt/

2 lines

3 lines

8 lines

receiverequestdialog.h

1 line

receiverequestdialog.cpp

25 lines

Diff 21384

src/qt/bitcoingui.cpp

Loading...

src/qt/guiutil.h

Loading...

src/qt/guiutil.cpp

Loading...

src/qt/receiverequestdialog.h

Loading...

src/qt/receiverequestdialog.cpp

Loading...