Page MenuHomePhabricator

Merge #14632: Tests: Fix a comment
ClosedPublic

Authored by jasonbcox on Apr 29 2020, 23:57.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCa05bd47c8e38: Merge #14632: Tests: Fix a comment
Summary

086fc83571 Tests: Fix a comment (fridokus)

Pull request description:

Fix a comment that was false

Tree-SHA512: 945aa38229545e026e18c3abf53a4fbe6ec36413ce690fff7a1dd89b6e102d2b574524092e0ddf06cace82f3c040c59221b9b942be1203525814d2fbd50aaa0b

Backport of Core PR14632

Test Plan

test_runner.py mempool_resurrect for sanity

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Apr 30 2020, 00:57

Snippet of first build failure:

[23:09:24] :		 [VCS Root: Bitcoin ABC Staging] checkout rules: =>bitcoin-abc; revision: b9ce1429ea276a06e6054f13564cdc17a9fa95a9
[23:09:24] :		 [VCS Root: Bitcoin ABC Staging] Git version: 2.20.1.0
[23:09:24] :		 [VCS Root: Bitcoin ABC Staging] Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git) (6s)
[23:09:24] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git config http.sslCAInfo
[23:09:24] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git show-ref
[23:09:25] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git -c credential.helper= ls-remote origin
[23:09:27] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git show-ref refs/tags/phabricator/diff/19270
[23:09:27] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git show-ref refs/tags/phabricator/diff/19270
[23:09:28] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19270:refs/tags/phabricator/diff/19270 (3s)
[23:09:30]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19270:refs/tags/phabricator/diff/19270] remote: Enumerating objects: 9, done.        
[23:09:30]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19270:refs/tags/phabricator/diff/19270] remote: Counting objects:  11% (1/9)        
[23:09:30]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19270:refs/tags/phabricator/diff/19270] remote: Counting objects:  22% (2/9)        
[23:09:30]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19270:refs/tags/phabricator/diff/19270] remote: Counting objects:  33% (3/9)        
[23:09:30]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19270:refs/tags/phabricator/diff/19270] remote: Counting objects:  44% (4/9)        
[23:09:30]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19270:refs/tags/phabricator/diff/19270] remote: Counting objects:  55% (5/9)        
[23:09:30]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19270:refs/tags/phabricator/diff/19270] remote: Counting objects:  66% (6/9)        
[23:09:30]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19270:refs/tags/phabricator/diff/19270] remote: Counting objects:  77% (7/9)        
[23:09:30]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19270:refs/tags/phabricator/diff/19270] remote: Counting objects:  88% (8/9)        
[23:09:30]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19270:refs/tags/phabricator/diff/19270] remote: Counting objects: 100% (9/9)        
[23:09:30]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19270:refs/tags/phabricator/diff/19270] remote: Counting objects: 100% (9/9), done.        
[23:09:31]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19270:refs/tags/phabricator/diff/19270] remote: Compressing objects:  25% (1/4)        
[23:09:31]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19270:refs/tags/phabricator/diff/19270] remote: Compressing objects:  50% (2/4)        
[23:09:31]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19270:refs/tags/phabricator/diff/19270] remote: Compressing objects:  75% (3/4)        
[23:09:31]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19270:refs/tags/phabricator/diff/19270] remote: Compressing objects: 100% (4/4)        
[23:09:31]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19270:refs/tags/phabricator/diff/19270] remote: Compressing objects: 100% (4/4), done.        
[23:09:31]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19270:refs/tags/phabricator/diff/19270] remote: Total 5 (delta 4), reused 2 (delta 1), pack-reused 0        
[23:09:31]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19270:refs/tags/phabricator/diff/19270] From ssh://reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging
[23:09:31]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19270:refs/tags/phabricator/diff/19270]  * [new tag]             phabricator/diff/19270 -> phabricator/diff/19270
[23:09:31] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git log -n1 --pretty=format:%H%x20%s b9ce1429ea276a06e6054f13564cdc17a9fa95a9 --
[23:09:31] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git pack-refs --all
[23:09:31] :		 [VCS Root: Bitcoin ABC Staging] Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)
[23:09:31] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] The .git directory is missing in '/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc'. Running 'git init'...
[23:09:31] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git init
[23:09:31] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config lfs.storage /home/teamcity/buildAgent/system/git/git-48AA3180.git/lfs
[23:09:31] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config core.sparseCheckout true
[23:09:31] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config http.sslCAInfo
[23:09:31] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref
[23:09:31] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/19270
[23:09:31] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git log -n1 --pretty=format:%H%x20%s b9ce1429ea276a06e6054f13564cdc17a9fa95a9 --
[23:09:31] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git -c credential.helper= checkout -q -f phabricator/diff/19270
[23:09:31] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/19270
[23:09:31] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] Cleaning Bitcoin ABC Staging in /home/teamcity/buildAgent/work/jailed-build/bitcoin-abc the file set ALL_UNTRACKED
[23:09:31] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git clean -f -d -x
[23:09:31] : Build preparation done
[23:09:31]E: Step 1/2: Command Line (4m)
[23:09:31] :	 [Step 1/2] Ant JUnit report watcher
[23:09:31] :		 [Ant JUnit report watcher] Watching paths:
[23:09:31] :		 [Ant JUnit report watcher] +:results/test_bitcoin.xml
[23:09:31] :		 [Ant JUnit report watcher] +:results/**/junit_results*.xml
[23:09:31] :	 [Step 1/2] Starting: /home/teamcity/buildAgent/temp/agentTmp/custom_script5443821756930273137
[23:09:31] :	 [Step 1/2] in directory: /home/teamcity/buildAgent/work/jailed-build
[23:09:31] :	 [Step 1/2] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[23:09:31] :	 [Step 1/2] ~/buildAgent/work/jailed-build
[23:09:31] :	 [Step 1/2] Building base image for: b9ce1429e...
[23:09:31] :	 [Step 1/2] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[23:09:33] :	 [Step 1/2] ~/buildAgent/work/jailed-build
[23:09:33] :	 [Step 1/2] Tag name: abc-base-image-b9ce1429e
[23:13:31] :	 [Step 1/2] [Infrastructure Error] Failed to pull 'abc-base-image-b9ce1429e' from registry. See agent logs for details.
[23:13:31]W:	 [Step 1/2] Process exited with code 1
[23:13:31]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)
This revision was automatically updated to reflect the committed changes.