Page MenuHomePhabricator
Differential D814

Add cmake/ninja build for the bitcoin-tx utility
ClosedPublic
Actions

Authored by deadalnix on Dec 16 2017, 00:40.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING81f3f81291c0: Add cmake/ninja build for the bitcoin-tx utility
rABC81f3f81291c0: Add cmake/ninja build for the bitcoin-tx utility
Summary

As per title.

I had to move some pieces around compared to the original design, but not a big deal because it wasn't making any sense anyway. It only works on the previous build system because of redundant linking.

Test Plan
ninja

Make sure the bitcoin-tx utility is built without errors.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmakeconsensus
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1390
Build 1390: arc lint + arc unit

Event Timeline

deadalnix created this revision.Dec 16 2017, 00:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 16 2017, 00:40
Harbormaster completed remote builds in B1390: Diff 2151.Dec 16 2017, 00:40
schancel accepted this revision.Dec 16 2017, 03:22
schancel added inline comments.
src/CMakeLists.txt
94

Are you intending to move these from consensus to common. The previous list of sources was different for these libraries.

This revision is now accepted and ready to land.Dec 16 2017, 03:22
Closed by commit rABC81f3f81291c0: Add cmake/ninja build for the bitcoin-tx utility (authored by deadalnix). · Explain WhyDec 16 2017, 12:56
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
29 lines

Diff 2151

View Options

src/CMakeLists.txt

Loading...