Page MenuHomePhabricator
Differential D6628

Merge #15824: docs: Improve netbase comments
ClosedPublic
Actions

Authored by nakihito on Jun 17 2020, 19:13.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC76df4df8e642: Merge #15824: docs: Improve netbase comments
Summary

c7f6ce74d3a5cf2a0c5bac20eab1efd997175a72 docs: Improve netbase comments (Carl Dong)

Pull request description:

Second in a series of PRs documenting the net stack. Contributed with sincere thanks to sipa, laanwj, and gmaxwell for providing much of the history, context, and rationale.

ACKs for top commit:

laanwj:
  ACK c7f6ce74d3a5cf2a0c5bac20eab1efd997175a72

Tree-SHA512: ad83054d3b8d0c8c3fb55be011bcf294176e7509513bf61326866afd53e8159644e0d59bb3a2f404717f525cbf736096d4c1990e61cfd89845d51fa6b5394b7c

Backport of Core PR15824

Test Plan
ninja

Diff Detail

Event Timeline

nakihito created this revision.Jun 17 2020, 19:13
Owners added a reviewer: Restricted Owners Package.Jun 17 2020, 19:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 17 2020, 19:13
nakihito requested review of this revision.Jun 17 2020, 19:13
teamcity edited the summary of this revision. (Show Details)Jun 17 2020, 19:13

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11550: Diff 21503.Jun 17 2020, 19:23
Fabien accepted this revision.Jun 18 2020, 10:13
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/netbase.cpp
455 ↗(On Diff #21503)

Move comment above

457 ↗(On Diff #21503)

Dito

461 ↗(On Diff #21503)

Dito

This revision is now accepted and ready to land.Jun 18 2020, 10:13
nakihito updated this revision to Diff 21529.Jun 18 2020, 17:04

Addressed nits.

Harbormaster completed remote builds in B11568: Diff 21529.Jun 18 2020, 17:16
Closed by commit rABC76df4df8e642: Merge #15824: docs: Improve netbase comments (authored by nakihito). · Explain WhyJun 18 2020, 22:17
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC76df4df8e642: Merge #15824: docs: Improve netbase comments.

Revision Contents
Changeset List

PathSize
src/
221 lines

Diff 21529

View Options

src/netbase.cpp

Loading...