Differential D6729

[refactor] Prep for scripted-diff by removing some \ns which annoy sed.
ClosedPublic
Actions

Authored by deadalnix on Jun 24 2020, 23:09.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCbc3fa66b8393: [refactor] Prep for scripted-diff by removing some \ns which annoy sed.

Summary

This is a redo of https://github.com/bitcoin/bitcoin/pull/15141/commits/7721ad64f40a0c67edefaaf7353264d78df8803e

I used some sed magic:

sed -n '/\.DoS(/{ :loop N; s/,\n\s*/, /; s/\n\s*//; /\.DoS(.*;/!b loop}; p' -i ../src/validation.cpp ../src/consensus/tx_verify.cpp

Test Plan

Loop at the result

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr15141-11

Lint

Lint Passed

Severity	Location	Code	Message
Auto-Fix	src/consensus/tx_verify.cpp:1	CFMT	Code style violation
Auto-Fix	src/validation.cpp:1	CFMT	Code style violation

Unit

No Test Coverage

Build Status

Buildable 11694
Build 22846: Default Diff Build & Tests	Link to the build
Build 22845: Build without Wallet	Link to the build
Build 22844: Build with clang-10	Link to the build
Build 22843: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 24 2020, 23:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 24 2020, 23:09

deadalnix requested review of this revision.Jun 24 2020, 23:09

Lint violations are the whole purpose of that patch.

majcosta accepted this revision.Jun 24 2020, 23:24

This revision is now accepted and ready to land.Jun 24 2020, 23:24

Harbormaster completed remote builds in B11694: Diff 21740.Jun 24 2020, 23:31

deadalnix added a child revision: D6730: scripted-diff: Remove DoS calls to CValidationState.Jun 24 2020, 23:31

Closed by commit rABCbc3fa66b8393: [refactor] Prep for scripted-diff by removing some \ns which annoy sed. (authored by Matt Corallo <git@bluematt.me>, committed by deadalnix). · Explain WhyJun 25 2020, 12:31

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCbc3fa66b8393: [refactor] Prep for scripted-diff by removing some \ns which annoy sed..

Revision Contents
Changeset List

Path

Size

src/

consensus/

tx_verify.cpp

30 lines

validation.cpp

163 lines

Diff 21740

View Options

src/consensus/tx_verify.cpp