Page MenuHomePhabricator
Differential D6730

scripted-diff: Remove DoS calls to CValidationState
ClosedPublic
Actions

Authored by deadalnix on Jun 24 2020, 23:31.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCcc54e8f8bc35: scripted-diff: Remove DoS calls to CValidationState
Summary

-BEGIN VERIFY SCRIPT-
sed -i 's/\.DoS(\(.*\), REJECT_\(.*\), \(true\|false\)/.DoS(\1, REJECT_\2/' src/validation.cpp src/consensus/tx_verify.cpp src/consensus/tx_check.cpp
sed -i 's/state.GetRejectCode(), state.GetRejectReason(), [^,]\+, state.GetDebugMessage())/state.GetRejectCode(), state.GetRejectReason(), state.GetDebugMessage())/' src/validation.cpp
sed -i 's/\.DoS([^,]*, /.Invalid\(/' src/validation.cpp src/consensus/tx_verify.cpp src/consensus/tx_check.cpp
-END VERIFY SCRIPT-

Co-authored-by: Suhas Daftuar <sdaftuar@gmail.com>

This is a backport of Core PR15141 : https://github.com/bitcoin/bitcoin/pull/15141/commits/aa502b88d10c2c3ac56d9163555849b96dc4df1e

Depends on D6729

Test Plan
ninja all check-all

Diff Detail

Event Timeline

deadalnix created this revision.Jun 24 2020, 23:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 24 2020, 23:31
deadalnix requested review of this revision.Jun 24 2020, 23:31
teamcity edited the summary of this revision. (Show Details)Jun 24 2020, 23:31

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix edited the summary of this revision. (Show Details)Jun 24 2020, 23:31
deadalnix added a parent revision: D6729: [refactor] Prep for scripted-diff by removing some \ns which annoy sed..
Harbormaster completed remote builds in B11695: Diff 21742.Jun 24 2020, 23:48
majcosta accepted this revision.Jun 24 2020, 23:59
This revision is now accepted and ready to land.Jun 24 2020, 23:59
Closed by commit rABCcc54e8f8bc35: scripted-diff: Remove DoS calls to CValidationState (authored by Matt Corallo <git@bluematt.me>, committed by deadalnix). · Explain WhyJun 25 2020, 12:41
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCcc54e8f8bc35: scripted-diff: Remove DoS calls to CValidationState.

Revision Contents
Changeset List

PathSize
src/
consensus/
47 lines
30 lines
162 lines

Diff 21742

View Options

src/consensus/tx_check.cpp

Loading...
View Options

src/consensus/tx_verify.cpp

Loading...
View Options

src/validation.cpp

Loading...