Page MenuHomePhabricator
Differential D825

Improve cmake's config file generation
ClosedPublic
Actions

Authored by deadalnix on Dec 18 2017, 01:21.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING411bb8c02a22: Improve cmake's config file generation
rABC411bb8c02a22: Improve cmake's config file generation
Summary

As per title. Using 1 instead of the value makes the end result more predictible.

Test Plan
ninja

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmakesketchy
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1409
Build 1409: arc lint + arc unit

Event Timeline

deadalnix created this revision.Dec 18 2017, 01:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 18 2017, 01:21
schancel requested changes to this revision.Dec 19 2017, 00:22
schancel added inline comments.
src/config/bitcoin-config.h.cmake.in
22

Seems like these would be better as #cmakedefine01

This revision now requires changes to proceed.Dec 19 2017, 00:22
deadalnix requested review of this revision.Dec 19 2017, 18:01
deadalnix added inline comments.
src/config/bitcoin-config.h.cmake.in
22

No, the semantic is different as cmake01 always define the symbol.

#if defined(FOO)

behaves differently.

schancel accepted this revision.Dec 19 2017, 19:08
This revision is now accepted and ready to land.Dec 19 2017, 19:08
Closed by commit rABC411bb8c02a22: Improve cmake's config file generation (authored by deadalnix). · Explain WhyDec 20 2017, 00:48
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
config/
54 lines

Diff 2182

View Options

src/config/bitcoin-config.h.cmake.in

Loading...