Page MenuHomePhabricator
Differential D6882

[backport#17080] consensus: Explain why fCheckDuplicateInputs can not be skipped and remove it
ClosedPublic
Actions

Authored by majcosta on Jul 9 2020, 20:50.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC28928b02751b: [backport#17080] consensus: Explain why fCheckDuplicateInputs can not be…
Summary

fa928134075220254a15107c1d9702f4e66271f8 consensus: Explain why fCheckDuplicateInputs can not be skipped and remove it (MarcoFalke)

Pull request description:

As a follow up to CVE-2018-17144, this removes the unused `fCheckDuplicateInputs` parameter and explains why the test can not be disabled. Apart from protecting against a dumb accident in the future, this should document the logic in the code. There is a technical write-up that explains how the underlying coins database behaves if this test is skipped: https://bitcoincore.org/en/2018/09/20/notice/#technical-details. However, it does not explicitly mention why the test can not be skipped. I hope my code comment does that.

Backport of Core PR17080

Test Plan
read the comment

Diff Detail

Event Timeline

majcosta created this revision.Jul 9 2020, 20:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2020, 20:50
majcosta requested review of this revision.Jul 9 2020, 20:50
teamcity edited the summary of this revision. (Show Details)Jul 9 2020, 20:50

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11937: Diff 22137.Jul 9 2020, 21:07
deadalnix accepted this revision.Jul 9 2020, 21:35
This revision is now accepted and ready to land.Jul 9 2020, 21:35
Closed by commit rABC28928b02751b: [backport#17080] consensus: Explain why fCheckDuplicateInputs can not be… (authored by Wladimir J. van der Laan <laanwj@protonmail.com>, committed by majcosta). · Explain WhyJul 9 2020, 21:49
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC28928b02751b: [backport#17080] consensus: Explain why fCheckDuplicateInputs can not be….

Revision Contents
Changeset List

PathSize
src/
consensus/
6 lines

Diff 22137

View Options

src/consensus/tx_check.cpp

Loading...