Page MenuHomePhabricator
Differential D7045

[backport#16620] util: Move ResolveErrMsg to util/error
ClosedPublic
Actions

Authored by majcosta on Jul 27 2020, 17:14.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC35f36b8ef112: [backport#16620] util: Move ResolveErrMsg to util/error
Summary

Pull request description:

Pull request https://github.com/bitcoin/bitcoin/pull/16248#discussion_r314035862 duplicated the body of this util function. The whole point of the util function is to be shared, so do that here as a fixup to #16248

https://github.com/bitcoin/bitcoin/pull/16620/commits/fa27c55b0593c769b6ad87de0b59df3816d73548

Backport of Core PR16620

Test Plan
ninja check check-functional

Diff Detail

Event Timeline

majcosta created this revision.Jul 27 2020, 17:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 27 2020, 17:14
majcosta requested review of this revision.Jul 27 2020, 17:14
Harbormaster completed remote builds in B12171: Diff 22532.Jul 27 2020, 17:27
Fabien accepted this revision.Jul 27 2020, 21:37
This revision is now accepted and ready to land.Jul 27 2020, 21:37
teamcity edited the summary of this revision. (Show Details)Jul 27 2020, 22:04

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Closed by commit rABC35f36b8ef112: [backport#16620] util: Move ResolveErrMsg to util/error (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyJul 28 2020, 08:16
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC35f36b8ef112: [backport#16620] util: Move ResolveErrMsg to util/error.

Revision Contents
Changeset List

PathSize
src/
6 lines
4 lines
util/
5 lines
6 lines

Diff 22532

View Options

src/init.cpp

Loading...
View Options

src/net_permissions.cpp

Loading...
View Options

src/util/error.h

Loading...
View Options

src/util/error.cpp

Loading...